Fix mutable script params for detector trigger actions (#1715)#1722
Open
thecodingshrimp wants to merge 1 commit into
Open
Fix mutable script params for detector trigger actions (#1715)#1722thecodingshrimp wants to merge 1 commit into
thecodingshrimp wants to merge 1 commit into
Conversation
…oject#1715) Signed-off-by: thecodingshrimp <leonard.stutzer@sap.com>
thecodingshrimp
requested review from
AWSHurneyt,
KashKondaka,
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
lezzago,
manaswini1920,
nishtham-amazon,
riysaxen-amzn,
toepkerd and
vikhy-aws
as code owners
Author
|
@andrross thx for encouraging |
Member
|
@AWSHurneyt Can a maintainer review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a detector create/update failure caused by using Java's immutable
Collections.emptyMap()when constructing trigger actionScriptobjects inDetectorTrigger#getActions().The Alerting plugin consumes these script params from Kotlin and expects a mutable map implementation. Replacing the immutable empty map with
new HashMap<>()prevents thekotlin.collections.EmptyMap cannot be cast to kotlin.collections.MutableMapexception and allows detector operations with trigger actions to succeed.Related Issues
Resolves #1715, #1553, #1721
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.