some things

[Marcel510]

Fail: runways is missing the following required keys: glideslope
Fail: runways is missing the following required keys: glideslope
Fail: runways is missing the following required keys: glideslope

Not sure if the glideslope key is really strictly required, I think it's only needed if you the glideslope angle is not 3.00° otherwise I think it can be left out and it will use the default value of 3.00°.

Invalid value "|S250-" supplied to {icao: String, name: String, body: IProcedureSegmentWaypoint, draw: Array<Array>, rwy: IProcedureSegment, entryPoints: IProcedureSegment}/body: IProcedureSegmentWaypoint/0: IProcedureSegmentWaypoint(IWaypointWithRestriction)/1: WaypointRestrictionType

This may be a valid complaint but I'm not sure. Anyway, it would be great if you could see which line the complaint refers to.

[n8rzz]

thanks @Marcel510 those are both good callouts!

I've created #9 to cover the first item. For the second item, I'm still working through more specific validations (and better messaging) for the segment restrictions.

If this is defined as: ["FIXXA", ["FIXXB", "|S250-"]], then this is a good validation error. If there is an altitude restriction before the speed restriction like: ["FIXXA", ["FIXXB", "A50|S250-"]], then this is a bug on my end.

[Marcel510]

I've just checked that and it was defined as: ["FIXXA", ["FIXXB", "|S250-"]].
So no bug on your end but still it would be good if there was the line number for easier error spotting.

[n8rzz]

Line numbers are a little out of scope for this but better messaging certainly is. Something I have in mind for this is listing the procedure from which this error was found.

[Marcel510]

That I'll work as well if that's easier to realise. Nate Geslin <notifications@github.com> schrieb am Fr., 22. Juni 2018, 17:35:

…

Line numbers are a little out of scope for this but better messaging certainly is. Something I have in mind for this is listing the procedure from which this error was found. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXrs4QOEYn-a9gS3UdCqu1mwY60OBmZIks5t_Q7VgaJpZM4Uzw0N> .