Skip to content

Move StringFormatted recipe from Java 17 upgrade to Java best practices #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 3 commits into from
May 21, 2026
+137 −151
Merged

Move StringFormatted recipe from Java 17 upgrade to Java best practices #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
252ddcd
Move StringFormatted recipe from Java 17 upgrade to Java best practices
timtebeek May 21, 2026
d24a876
Set addParentheses: true for StringFormatted in best practices
timtebeek May 21, 2026
d8cacdf
Drop StringFormatted expectations from Java 17 upgrade tests
timtebeek May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/resources/META-INF/rewrite/java-best-practices.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ recipeList:
# Text blocks for strings without newlines (upgrade chain only does convertStringsWithoutNewlines: false)
- org.openrewrite.java.migrate.lang.UseTextBlocks:
convertStringsWithoutNewlines: true
# Prefer String.formatted() over String.format()
- org.openrewrite.java.migrate.lang.StringFormatted:
addParentheses: true
# Prefer Java standard library over Guava where possible
- org.openrewrite.java.migrate.guava.NoGuava
# Prefer Java standard library over Joda-Time where possible
Expand Down
2 changes: 0 additions & 2 deletions src/main/resources/META-INF/rewrite/java-version-17.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ recipeList:
- org.openrewrite.java.migrate.lang.ExplicitRecordImport
- org.openrewrite.java.migrate.lang.UseTextBlocks:
convertStringsWithoutNewlines: false
- org.openrewrite.java.migrate.lang.StringFormatted:
addParentheses: false
- org.openrewrite.java.migrate.DeprecatedJavaxSecurityCert
- org.openrewrite.java.migrate.DeprecatedLogRecordThreadID
- org.openrewrite.java.migrate.RemovedLegacySunJSSEProviderName
Expand Down
Loading
Loading