ci: enable macOS-15 build#304
Open
gmarzot wants to merge 1 commit into
Open
Conversation
gmarzot
requested review from
Oxyd,
TimEvens,
afrind,
akash-a-n,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
gmarzot
force-pushed
the
feature/macos-ci
branch
2 times, most recently
from
bb64e51 to
9638c53
Compare
Bumps the moxygen submodule to fix/macos-openssl-stable-path-omoq (2540d9e9), which carries the cmake fix steering find_package(OpenSSL) through brew's stable opt-symlink instead of versioned Cellar paths. Mirrors facebookexperimental/moxygen#162; will revert the submodule bump once that lands and syncs into openmoq/moxygen main. CI's three-mode setup auto-detects the off-main submodule SHA and falls back to source build, so the macOS job builds moxygen from the patched branch rather than the snapshot tarball. Conformance and publish for macOS deferred to follow-up PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP — do not merge yet. Depends on facebookexperimental/moxygen#162 syncing into openmoq/moxygen main.
What this does
Enables the macOS-15 (Apple Silicon) build job in both `ci-pr.yml` and `ci-main.yml`. The matrix entry was previously commented out with the comment "moxygen tarball bakes brew Cellar versioned paths that break when the runner has different brew package versions" — that's the issue addressed by facebookexperimental/moxygen#162.
Bumps `deps/moxygen` submodule to `2540d9e9` on branch `fix/macos-openssl-stable-path-omoq` (a temporary openmoq-side carry of the same patch). CI's three-mode setup detects the off-main SHA and auto-falls back to source build, so the macOS job builds moxygen from the patched branch rather than the (broken) snapshot tarball.
Testing so far
Verified end-to-end on argo (macOS Apple Silicon, M-series):
```
==> Moxygen submodule SHA: 2540d9e
==> Snapshot release SHA: 9f6bee4
Error: snapshot-latest does not match the moxygen submodule pin.
Release artifacts not available — falling back to source build...
```
```
$ grep -rE 'Cellar/openssl@3' .scratch/moxygen-install/lib/cmake/
(empty)
$ grep -rE 'opt/openssl@3' .scratch/moxygen-install/lib/cmake/ | head
fizz/fizz-targets.cmake: .../opt/openssl@3/lib/libssl.dylib...
folly/folly-targets.cmake: .../opt/openssl@3/include...
```
Scope
Path to merge
```
Closes openmoq/moxygen carry branch 'fix/macos-openssl-stable-path-omoq'.
```
This change is