PR #457's auto-approval behavior is now covered well, but a few negative/dedup checks still use short Task.Delay(...) waits to prove something did not happen, and one path depends on the production 1s reconnect delay.
Follow-up:
- Replace timing-based negative assertions with deterministic completion/synchronization signals.
- Consider injecting a delay/time provider into
GatewayConnectionManager so tests can set the post-approve reconnect delay to zero.
- Preserve coverage for: other-node requests are ignored, missing approval scope is ignored, duplicate request IDs are not approved twice, and node-side skipped attempts do not suppress later operator-side approval.
Context: identified during review of #457.
PR #457's auto-approval behavior is now covered well, but a few negative/dedup checks still use short
Task.Delay(...)waits to prove something did not happen, and one path depends on the production 1s reconnect delay.Follow-up:
GatewayConnectionManagerso tests can set the post-approve reconnect delay to zero.Context: identified during review of #457.