Skip to content

fix(brew): suppress cask stdout/stderr during install #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fullstackjam merged 2 commits into from
May 20, 2026
Merged

fix(brew): suppress cask stdout/stderr during install #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ddaba7
fix(brew): suppress cask stdout/stderr during install
fullstackjam May 20, 2026
3d6404d
chore: update archtest baseline for shifted line numbers
fullstackjam May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/archtest/baseline/no-direct-exec.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Each line is <file>:<line> of a known existing violation.
# Regenerate: ARCHTEST_UPDATE_BASELINE=1 go test ./internal/archtest/...
internal/auth/login.go:191
internal/brew/brew_install.go:337
internal/brew/brew_install.go:328
internal/cli/snapshot.go:21
internal/diff/compare.go:247
internal/diff/compare.go:253
Expand Down
21 changes: 6 additions & 15 deletions internal/brew/brew_install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,11 @@ func InstallWithProgress(cliPkgs, caskPkgs []string, dryRun bool) (installedForm
return installedFormulae, installedCasks, nil
}

// installCasksWithProgress installs cask packages one by one, letting brew's
// own output (download progress, etc.) scroll through. Returns successful
// installs and failed jobs.
// installCasksWithProgress installs cask packages one by one with brew output
// suppressed. Returns successful installs and failed jobs.
func installCasksWithProgress(pkgs []string, progress *ui.StickyProgress) (installed []string, failed []failedJob) {
for _, pkg := range pkgs {
progress.SetCurrent(pkg)
progress.PrintLine(" Installing %s...", pkg)

start := time.Now()
errMsg := installCaskWithProgress(pkg)
Expand Down Expand Up @@ -313,18 +311,11 @@ func runSerialInstallWithProgress(pkgs []string, progress *ui.StickyProgress) []
}

func installCaskWithProgress(pkg string) string {
cmd := brewInstallCmd("install", "--cask", pkg)
tty, opened := system.OpenTTY()
if opened {
defer tty.Close() //nolint:errcheck // best-effort TTY cleanup
}
cmd.Stdin = tty
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
if err := cmd.Run(); err != nil {
return "install failed"
output, err := brewCombinedOutputWithTTY("install", "--cask", pkg)
if err == nil {
return ""
}
return ""
return parseBrewError(output)
}

// Runner-exempt: this helper sets HOMEBREW_NO_AUTO_UPDATE=1 and returns a raw
Expand Down
Loading