Commit 1cbe170
chore(harness): fix knip drift signal and drift-to-issue trigger
Two fixes after the first Harness run on main surfaced design bugs:
1. drift-to-issue.yml never fires. Its `if:
github.event.workflow_run.conclusion == 'failure'` guard is
unreachable, because Harness jobs set `continue-on-error: true`,
which makes the workflow conclude `success` even when individual
sensors fail. Drop the workflow-level guard and rely on the
job-level conclusion loop already inside the Python script — jobs
that pass are a silent no-op.
2. knip noise drowned the real signal. Add knip.json that:
- Registers SearchModal.svelte as an entry point (loaded via
dynamic `await import()` from docs/+layout.svelte, which knip's
static analysis can't see).
- Ignores `@cloudflare/workers-types` as a type-only transitive
pulled in by @sveltejs/adapter-cloudflare.
- Disables the noisy "unused exports / types / namespace members"
rules (these flag internal API surface and rarely yield real work).
With the filter in place, knip surfaced real drift: codemirror and
svelte-codemirror-editor were declared but never imported; the raw
@codemirror/{view,state,commands} were imported by ShellEditor.svelte
but not declared in package.json (working only via transitive
resolution); @testing-library/svelte was a devDep with no callers.
Removed the unused, added the missing — knip exits clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 1b19b18 commit 1cbe170
4 files changed
Lines changed: 28 additions & 240 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments