Changed the the request header in TriggerWorkflowController to handle Complex hash #18951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller by simplifing the Lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey friends,
I have tried to fix the 'can't create hash to float' TypeError in the trigger_workflow .
I think that we were previously looping through header keys and performing a lookup for every item, which causes a crash when complex hashes were encountered.
The final logic of the request header remain same but we are now iterating over
request.headers.to_hdirectly as |k, v|, So we can bypass therequest.headers[k]and safely process the hash values.Also please let me know if some test are required to verify the fix.
Fixes : #15699
Thanks !