Made the event listener more specific in diff comment #18946
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review app will appear here: http://obs-reviewlab.opensuse.org/digvijay-x1-fixdiff_comment |
krauselukas
approved these changes
Dec 9, 2025
Contributor
krauselukas
left a comment
krauselukas
left a comment
There was a problem hiding this comment.
Great! Thanks @Digvijay-x1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #18736
Hey friends ,
I have tried to fix the disappearing bug when clicking "EDIT" .
My findings ,
I think the global
comment.jswill close other forms when clicked "EDIT" by programmatic clicking "Cancel" button.I think this is that part in
comment.js// Toggle visibility of edit form of the same comment$(document).on('click', '[id*="reply_button_of_"]', function (e) { const idNumber = $(e.target).attr('id').split('reply_button_of_')[1]; $('#edit_form_of_' + idNumber + ' .cancel-comment').click(); });Now the
inline_comment.js.erbis too broad and will listen to any.cancel-commentand will reset the thread .$("#comment<%= @line %>").on('click', '.cancel-comment', function (e) {So i changed it to be more specific and only work for
.cancel-commentfrom the new comment .Result :
Screencast.From.2025-12-04.18-04-34.mp4
Thanks !