Merge pull request #140 from skylavis-sky/fix/pancakeswap-v2-skill-dry-run-url

fix(pancakeswap-v2): v0.2.3 — human-readable amounts, --dry-run docs, erc20_decimals consolidation

Author: mig-pre

skills/pancakeswap-v2/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "pancakeswap-v2",
   "description": "Swap tokens and manage liquidity on PancakeSwap V2 (xyk AMM) on BSC, Base, and Arbitrum. Triggers: swap pancakeswap v2, add/remove liquidity pancake, pcs v2 quote, check pancake pair.",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "author": { "name": "skylavis-sky", "github": "skylavis-sky" },
   "license": "MIT"
 }

skills/pancakeswap-v2/.gitignore

@@ -1 +1 @@
-target/
+/target/

skills/pancakeswap-v2/Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "pancakeswap-v2"
-version = "0.2.2"
+version = "0.2.3"
 edition = "2021"
 
 [[bin]]

skills/pancakeswap-v2/Cargo.toml

@@ -1,7 +1,7 @@
 ---
 name: pancakeswap-v2
 description: "Swap tokens and manage liquidity on PancakeSwap V2 (xyk AMM) on BSC, Base, and Arbitrum. Triggers: swap pancakeswap v2, add/remove liquidity pancake, pcs v2 quote, check pancake pair."
-version: "0.2.2"
+version: "0.2.3"
 author: "skylavis-sky"
 tags:
   - dex
@@ -36,7 +36,9 @@ npx skills add okx/plugin-store --skill plugin-store --yes --global
 ### Install pancakeswap-v2 binary (auto-injected)
 
 ```bash
-if ! command -v pancakeswap-v2 >/dev/null 2>&1; then
+REQUIRED_VERSION="0.2.3"
+INSTALLED_VERSION=$(pancakeswap-v2 --version 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1)
+if [ "$INSTALLED_VERSION" != "$REQUIRED_VERSION" ]; then
   OS=$(uname -s | tr A-Z a-z)
   ARCH=$(uname -m)
   EXT=""
@@ -50,9 +52,26 @@ if ! command -v pancakeswap-v2 >/dev/null 2>&1; then
     mingw*_x86_64|msys*_x86_64|cygwin*_x86_64)   TARGET="x86_64-pc-windows-msvc"; EXT=".exe" ;;
     mingw*_i686|msys*_i686|cygwin*_i686)           TARGET="i686-pc-windows-msvc"; EXT=".exe" ;;
     mingw*_aarch64|msys*_aarch64|cygwin*_aarch64)  TARGET="aarch64-pc-windows-msvc"; EXT=".exe" ;;
+    *) echo "Unsupported platform: ${OS}_${ARCH}"; exit 1 ;;
   esac
+  BASE_URL="https://github.com/okx/plugin-store/releases/download/plugins/pancakeswap-v2@${REQUIRED_VERSION}"
   mkdir -p ~/.local/bin
-  curl -fsSL "https://github.com/okx/plugin-store/releases/download/plugins/pancakeswap-v2@0.2.1/pancakeswap-v2-${TARGET}${EXT}" -o ~/.local/bin/pancakeswap-v2${EXT}
+  curl -fsSL "${BASE_URL}/checksums.txt" -o /tmp/pancakeswap-v2-checksums.txt
+  curl -fsSL "${BASE_URL}/pancakeswap-v2-${TARGET}${EXT}" -o ~/.local/bin/pancakeswap-v2${EXT}
+  EXPECTED=$(grep "pancakeswap-v2-${TARGET}${EXT}" /tmp/pancakeswap-v2-checksums.txt | awk '{print $1}')
+  if command -v sha256sum >/dev/null 2>&1; then
+    ACTUAL=$(sha256sum ~/.local/bin/pancakeswap-v2${EXT} | awk '{print $1}')
+  elif command -v shasum >/dev/null 2>&1; then
+    ACTUAL=$(shasum -a 256 ~/.local/bin/pancakeswap-v2${EXT} | awk '{print $1}')
+  else
+    echo "Warning: cannot verify checksum (no sha256sum or shasum found)" && ACTUAL="$EXPECTED"
+  fi
+  if [ "$ACTUAL" != "$EXPECTED" ]; then
+    echo "Checksum mismatch for pancakeswap-v2-${TARGET}${EXT} — aborting install"
+    rm -f ~/.local/bin/pancakeswap-v2${EXT} /tmp/pancakeswap-v2-checksums.txt
+    exit 1
+  fi
+  rm -f /tmp/pancakeswap-v2-checksums.txt
   chmod +x ~/.local/bin/pancakeswap-v2${EXT}
 fi
 ```
@@ -71,7 +90,7 @@ if [ ! -f "$REPORT_FLAG" ]; then
   unset _K
   curl -s -X POST "https://plugin-store-dun.vercel.app/install" \
     -H "Content-Type: application/json" \
-    -d '{"name":"pancakeswap-v2","version":"0.2.1"}' >/dev/null 2>&1 || true
+    -d '{"name":"pancakeswap-v2","version":"0.2.3"}' >/dev/null 2>&1 || true
   curl -s -X POST "https://www.okx.com/priapi/v1/wallet/plugins/download/report" \
     -H "Content-Type: application/json" \
     -d '{"pluginName":"pancakeswap-v2","divId":"'"$DIV_ID"'"}' >/dev/null 2>&1 || true
@@ -86,6 +105,19 @@ fi
 
 Before executing any write operation, verify the environment is ready:
 
+> **Version check**: Run `pancakeswap-v2 --version` and confirm it prints `pancakeswap-v2 0.2.3`. If the installed version is older, force-reinstall:
+> ```bash
+> OS=$(uname -s | tr A-Z a-z); ARCH=$(uname -m)
+> case "${OS}_${ARCH}" in
+>   darwin_arm64)  TARGET="aarch64-apple-darwin" ;;
+>   darwin_x86_64) TARGET="x86_64-apple-darwin" ;;
+>   linux_x86_64)  TARGET="x86_64-unknown-linux-gnu" ;;
+>   linux_aarch64) TARGET="aarch64-unknown-linux-gnu" ;;
+> esac
+> curl -fsSL "https://github.com/okx/plugin-store/releases/download/plugins/pancakeswap-v2@0.2.3/pancakeswap-v2-${TARGET}" \
+>   -o ~/.local/bin/pancakeswap-v2 && chmod +x ~/.local/bin/pancakeswap-v2
+> ```
+
 ```bash
 # Check onchainos version (requires >= 0.1.0)
 onchainos --version
@@ -116,11 +148,32 @@ Do NOT use for: PancakeSwap V3 swaps (use pancakeswap skill), concentrated liqui
 - Supports BSC (chain 56, default), Base (chain 8453), and Arbitrum One (chain 42161)
 - V2 uses constant-product xyk formula; LP tokens are standard ERC-20 (not NFTs); fixed 0.25% swap fee
 
+## Global Flags
+
+These flags apply to the **entire binary** and must be placed **before** the subcommand:
+
+| Flag | Default | Description |
+|------|---------|-------------|
+| `--chain <id>` | `56` | Chain ID: 56 (BSC), 8453 (Base), 42161 (Arbitrum) |
+| `--dry-run` | false | Simulate without broadcasting — no onchainos call made |
+| `--slippage-bps <n>` | `50` | Slippage tolerance in basis points (50 = 0.5%) |
+| `--deadline-secs <n>` | `300` | Transaction deadline in seconds from now |
+| `--from <address>` | wallet | Override sender address |
+| `--rpc-url <url>` | (chain default) | Override RPC endpoint |
+
+**Correct usage pattern:**
+```
+pancakeswap-v2 --dry-run --chain 56 swap --token-in USDT --token-out CAKE --amount-in 100
+pancakeswap-v2 --dry-run --chain 56 add-liquidity --token-a USDT --token-b BNB --amount-a 100 --amount-b 0.05
+```
+
+> ⚠️ `--dry-run` does **not** appear in subcommand `--help` output because it is a global flag. Always pass it before the subcommand name.
+
 ## Execution Flow for Write Operations
 
-1. Run with `--dry-run` first to preview calldata and estimated amounts
+1. Run with `pancakeswap-v2 --dry-run --chain <id> <command> ...` to preview calldata and estimated amounts
 2. **Ask user to confirm** the transaction details before proceeding
-3. Execute only after explicit user approval
+3. Execute only after explicit user approval (re-run without `--dry-run`)
 4. Report transaction hash and block explorer link
 
 ---
@@ -145,15 +198,15 @@ Do NOT use for: PancakeSwap V3 swaps (use pancakeswap skill), concentrated liqui
 
 **Usage:**
 ```
-pancakeswap-v2 --chain 56 quote --token-in USDT --token-out CAKE --amount-in 100000000000000000000
+pancakeswap-v2 --chain 56 quote --token-in USDT --token-out CAKE --amount-in 100
 ```
 
 **Parameters:**
 | Name | Flag | Description |
 |------|------|-------------|
 | tokenIn | `--token-in` | Input token: symbol (USDT, CAKE, WBNB) or hex address |
 | tokenOut | `--token-out` | Output token: symbol or hex address |
-| amountIn | `--amount-in` | Input amount in minimal units (e.g. 100e18 = 100 tokens for 18-decimal token) |
+| amountIn | `--amount-in` | Input amount as a human-readable decimal (e.g. 100, 1.5, 0.001) |
 | chain | `--chain` | Chain ID: 56 (BSC, default), 8453 (Base), or 42161 (Arbitrum) |
 
 **Example output:**
@@ -185,21 +238,24 @@ Read-only operation — no confirmation required.
 
 **Usage:**
 ```
-pancakeswap-v2 --chain 56 swap --token-in USDT --token-out CAKE --amount-in 100000000000000000000
+# Live swap
+pancakeswap-v2 --chain 56 swap --token-in USDT --token-out CAKE --amount-in 100
+# Dry-run preview (--dry-run is a global flag, goes before the subcommand)
+pancakeswap-v2 --dry-run --chain 56 swap --token-in USDT --token-out CAKE --amount-in 100
 ```
 
 **Parameters:**
 | Name | Flag | Description |
 |------|------|-------------|
 | tokenIn | `--token-in` | Input token: symbol or address. Use BNB/ETH for native |
 | tokenOut | `--token-out` | Output token: symbol or address |
-| amountIn | `--amount-in` | Input amount in minimal units |
-| slippageBps | `--slippage-bps` | Slippage in basis points (default 50 = 0.5%) |
-| deadlineSecs | `--deadline-secs` | Seconds until deadline (default 300) |
-| dryRun | `--dry-run` | Preview calldata only, no broadcast |
+| amountIn | `--amount-in` | Input amount as a human-readable decimal (e.g. 100, 1.5, 0.001) |
+| slippageBps | `--slippage-bps` | Slippage in basis points (default 50 = 0.5%) — global flag |
+| deadlineSecs | `--deadline-secs` | Seconds until deadline (default 300) — global flag |
+| dryRun | `--dry-run` | Preview calldata only, no broadcast — **global flag, place before subcommand** |
 
 **Execution flow:**
-1. Run `--dry-run` to preview the swap calldata and expected output
+1. Run `pancakeswap-v2 --dry-run --chain 56 swap ...` to preview the swap calldata and expected output
 2. **Ask user to confirm** the swap details (tokenIn, tokenOut, amountIn, amountOutMin, slippage)
 3. If tokenIn is an ERC-20 and allowance is insufficient, first submit an exact-amount approve tx via `onchainos wallet contract-call`; **ask user to confirm** the approval
 4. Submit swap via `onchainos wallet contract-call`
@@ -230,25 +286,28 @@ pancakeswap-v2 --chain 56 swap --token-in USDT --token-out CAKE --amount-in 1000
 **Usage:**
 ```
 # Token + Token
-pancakeswap-v2 --chain 56 add-liquidity --token-a CAKE --token-b USDT --amount-a 10000000000000000000 --amount-b 50000000000000000000
+pancakeswap-v2 --chain 56 add-liquidity --token-a CAKE --token-b USDT --amount-a 10 --amount-b 50
 
 # Token + native BNB
-pancakeswap-v2 --chain 56 add-liquidity --token-a CAKE --token-b BNB --amount-a 10000000000000000000 --amount-b 50000000000000000
+pancakeswap-v2 --chain 56 add-liquidity --token-a CAKE --token-b BNB --amount-a 10 --amount-b 0.05
+
+# Dry-run preview (--dry-run is a global flag, goes before the subcommand)
+pancakeswap-v2 --dry-run --chain 56 add-liquidity --token-a USDT --token-b BNB --amount-a 100 --amount-b 0.05
 ```
 
 **Parameters:**
 | Name | Flag | Description |
 |------|------|-------------|
 | tokenA | `--token-a` | First token: symbol or address. Use BNB/ETH for native |
 | tokenB | `--token-b` | Second token. Use BNB/ETH for native |
-| amountA | `--amount-a` | Desired amount of tokenA in minimal units |
-| amountB | `--amount-b` | Desired amount of tokenB (or native BNB/ETH) in minimal units |
-| slippageBps | `--slippage-bps` | Slippage tolerance (default 50 = 0.5%) |
-| dryRun | `--dry-run` | Preview calldata only |
+| amountA | `--amount-a` | Desired amount of tokenA as a human-readable decimal (e.g. 10, 0.5) |
+| amountB | `--amount-b` | Desired amount of tokenB (or native BNB/ETH) as a human-readable decimal |
+| slippageBps | `--slippage-bps` | Slippage tolerance (default 50 = 0.5%) — global flag |
+| dryRun | `--dry-run` | Preview calldata only — **global flag, place before subcommand** |
 
 **Execution flow:**
 1. Check current pair reserves and ratio
-2. Run `--dry-run` to preview the transaction
+2. Run `pancakeswap-v2 --dry-run --chain 56 add-liquidity ...` to preview the transaction
 3. **Ask user to confirm** the amounts and LP token receipt before proceeding
 4. Approve Router02 to spend the exact tokenA/tokenB amounts via `onchainos wallet contract-call` (if needed); **ask user to confirm** each approval
 5. Submit `addLiquidity` or `addLiquidityETH` via `onchainos wallet contract-call`
@@ -266,22 +325,22 @@ pancakeswap-v2 --chain 56 add-liquidity --token-a CAKE --token-b BNB --amount-a
 pancakeswap-v2 --chain 56 remove-liquidity --token-a CAKE --token-b USDT
 
 # Remove specific amount
-pancakeswap-v2 --chain 56 remove-liquidity --token-a CAKE --token-b USDT --liquidity 1000000000000000000
+pancakeswap-v2 --chain 56 remove-liquidity --token-a CAKE --token-b USDT --liquidity 1.0
 ```
 
 **Parameters:**
 | Name | Flag | Description |
 |------|------|-------------|
 | tokenA | `--token-a` | First token |
 | tokenB | `--token-b` | Second token. Use BNB/ETH to receive native |
-| liquidity | `--liquidity` | LP tokens to burn (minimal units). Omit to remove all |
-| slippageBps | `--slippage-bps` | Slippage tolerance (default 50 = 0.5%) |
-| dryRun | `--dry-run` | Preview only |
+| liquidity | `--liquidity` | LP tokens to burn as a human-readable decimal (e.g. 1.0). Omit to remove all |
+| slippageBps | `--slippage-bps` | Slippage tolerance (default 50 = 0.5%) — global flag |
+| dryRun | `--dry-run` | Preview only — **global flag, place before subcommand** |
 
 **Execution flow:**
 1. Fetch LP balance and compute expected token withdrawals
 2. Display summary: LP amount, expected tokenA and tokenB out
-3. Run `--dry-run` to preview calldata
+3. Run `pancakeswap-v2 --dry-run --chain 56 remove-liquidity ...` to preview calldata
 4. **Ask user to confirm** the removal details before proceeding
 5. Approve LP tokens to Router02 via `onchainos wallet contract-call`; **ask user to confirm**
 6. Submit `removeLiquidity` or `removeLiquidityETH` via `onchainos wallet contract-call`
@@ -360,6 +419,20 @@ For Arbitrum One (42161): WETH `0x82aF49447D8a07e3bd95BD0d56f35241523fBab1`, USD
 
 ## Changelog
 
+### v0.2.3 (2026-04-11)
+
+- **fix**: `--amount-in`, `--amount-a`, `--amount-b`, and `--liquidity` now accept human-readable decimal input (e.g. `1.5`, `100`, `0.001`). Previously clap rejected decimal values at parse time with "invalid digit found in string" because those args were typed `u128`. Changed to `String` and added `parse_human_amount()` which resolves each token's ERC-20 `decimals()` on-chain and converts to raw units.
+- **feat**: `pancakeswap-v2 --version` now works (added `version` to `#[command(...)]` attribute)
+- **fix**: `.gitignore` uses `/target/` (anchored) instead of `target/`
+- **fix**: consolidate duplicate `erc20_decimals` / `get_erc20_decimals` into single function in `rpc.rs`
+- **docs**: Added Global Flags section explaining that `--dry-run`, `--chain`, `--slippage-bps`, `--deadline-secs`, `--from`, `--rpc-url` are root-level flags and must be placed **before** the subcommand
+- **docs**: Updated Usage examples for `swap`, `add-liquidity`, and `remove-liquidity` to show correct `--dry-run` placement
+
+### v0.2.2 (2026-04-11)
+
+- **fix**: `remove-liquidity` overflow protection upgraded from pure f64 to `safe_mul_div` — tries `checked_mul` first (exact integer arithmetic for small pools), falls back to f64 only when `reserve × lp_balance` would overflow u128 (e.g. BSC BNB/USDT ~$17M TVL). Behavior is identical for all affected pools; change improves precision for pools below the overflow threshold.
+- **fix**: Exact-amount ERC-20 approvals (not unlimited) — approves the exact swap/LP amount rather than `uint256.max`
+
 ### v0.2.1 (2026-04-11)
 
 - **fix**: Arbitrum RPC URL updated from `arb1.arbitrum.io/rpc` to `arbitrum-one-rpc.publicnode.com` for consistency with BSC/Base (both use publicnode endpoints)

skills/pancakeswap-v2/SKILL.md

@@ -1,6 +1,6 @@
 schema_version: 1
 name: pancakeswap-v2
-version: "0.2.2"
+version: "0.2.3"
 description: "Swap tokens and manage liquidity on PancakeSwap V2 (xyk AMM) on BSC, Base, and Arbitrum. Triggers: swap pancakeswap v2, add/remove liquidity pancake, pcs v2 quote, check pancake pair."
 author:
   name: skylavis-sky