Fail fast on invalid STACKS_NETWORK values

Author: warmidris

README.md

@@ -287,6 +287,8 @@ misconfiguration.
 Integer env vars must be plain integer text (for example `10000`, not `10s`
 or `12.5`); malformed numeric values fail fast instead of being silently
 coerced.
+`STACKS_NETWORK` accepts only `mainnet`, `testnet`, `devnet`, or `mocknet`
+(case-insensitive); invalid values fail fast instead of silently defaulting.
 Observer ingress controls:
 
 - `STACKFLOW_NODE_OBSERVER_LOCALHOST_ONLY` defaults to `true` and restricts

server/src/config.ts

@@ -121,10 +121,16 @@ function normalizeBaseUrl(input: string): string {
 
 function parseNetwork(value: unknown): 'mainnet' | 'testnet' | 'devnet' | 'mocknet' {
   const normalized = String(value || 'devnet').trim().toLowerCase();
-  if (normalized === 'mainnet' || normalized === 'testnet' || normalized === 'mocknet') {
+  if (
+    normalized === 'mainnet' ||
+    normalized === 'testnet' ||
+    normalized === 'devnet' ||
+    normalized === 'mocknet'
+  ) {
     return normalized;
   }
-  return 'devnet';
+
+  throw new Error('STACKS_NETWORK must be one of: mainnet, testnet, devnet, mocknet');
 }
 
 function parseSignatureVerifierMode(value: unknown): SignatureVerifierMode {

tests/stackflow-node-config.test.ts

@@ -97,6 +97,14 @@ describe('stackflow-node config parsing', () => {
     ).toThrow(/STACKFLOW_NODE_PEER_WRITE_RATE_LIMIT_PER_MINUTE must be an integer/);
   });
 
+  it('fails fast when integer env vars exceed safe integer bounds', () => {
+    expect(() =>
+      loadConfig({
+        STACKFLOW_NODE_MAX_RECENT_EVENTS: '9007199254740992',
+      }),
+    ).toThrow(/STACKFLOW_NODE_MAX_RECENT_EVENTS must be a safe integer/);
+  });
+
   it('rejects stackflow-node ports outside the TCP range', () => {
     expect(() =>
       loadConfig({
@@ -151,6 +159,12 @@ describe('stackflow-node config parsing', () => {
       }),
     ).toThrow(/COUNTERPARTY_SIGNER_MODE/);
 
+    expect(() =>
+      loadConfig({
+        STACKS_NETWORK: 'dev',
+      }),
+    ).toThrow(/STACKS_NETWORK must be one of/);
+
     expect(() =>
       loadConfig({
         STACKFLOW_NODE_STACKFLOW_MESSAGE_VERSION: '版本',