Merge pull request #23 from gyant/ryanthompson/fix-schema-backup-error

maorfr · web-flow · commit bdb22f59c45b · 2020-09-22T12:39:36.000+03:00
Makes BackupKeyspaceSchema return an error on failure
diff --git a/pkg/cain/cqlsh.go b/pkg/cain/cqlsh.go
@@ -29,7 +29,7 @@ func BackupKeyspaceSchema(iK8sClient, iDstClient interface{}, namespace, pod, co
 
 	reader := bytes.NewReader(schema)
 	if err := skbn.Upload(iDstClient, dstPrefix, schemaToPath, "", reader); err != nil {
-		return "", nil
+		return "", err
 	}
 
 	return dstBasePath, nil

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func BackupKeyspaceSchema(iK8sClient, iDstClient interface{}, namespace, pod, co`
`29`	`29`
`30`	`30`	`reader := bytes.NewReader(schema)`
`31`	`31`	`if err := skbn.Upload(iDstClient, dstPrefix, schemaToPath, "", reader); err != nil {`
`32`		`- return "", nil`
	`32`	`+ return "", err`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`return dstBasePath, nil`