refactor(dialogs): extract goal config into dedicated dialog

- GoalConfigWidget was embedded inline in EditScheduledTaskDialog,
  bloating the form and coupling unrelated concerns
- Moving it into GoalAgentConfigDialog lets the scheduled task dialog
  stay compact (480px vs 700px) and opens config only on demand
- Storing ScheduledTaskGoalConfig by value (m_goalConfigData) instead
  of reading live widget state simplifies taskResult() and avoids
  partial reads if the sub-dialog is never opened
- Cron AI button now disables during the async request to prevent
  double-fires and gives visual feedback via "..." label
- Table column sizing switched from resizeColumnsToContents() on every
  refresh to static ResizeMode assignments, eliminating repeated layout
  passes on the hot refresh path

Author: nullmastermind

src/CMakeLists.txt

@@ -202,6 +202,8 @@ qt_add_executable(NotepadAI
 	dialogs/ScheduledTaskDialog.h
 	dialogs/EditScheduledTaskDialog.cpp
 	dialogs/EditScheduledTaskDialog.h
+	dialogs/GoalAgentConfigDialog.cpp
+	dialogs/GoalAgentConfigDialog.h
 	dialogs/EditTasksDialog.cpp
 	dialogs/EditTasksDialog.h
 	dialogs/EditMiniAppsDialog.cpp

src/dialogs/EditScheduledTaskDialog.cpp

@@ -24,7 +24,6 @@
 #include <QDir>
 #include <QFileDialog>
 #include <QFormLayout>
-#include <QGroupBox>
 #include <QHBoxLayout>
 #include <QInputDialog>
 #include <QLabel>
@@ -40,7 +39,7 @@
 #include "AcpAgentRegistry.h"
 #include "ApplicationSettings.h"
 #include "CronExpression.h"
-#include "GoalConfigWidget.h"
+#include "GoalAgentConfigDialog.h"
 #include "NotepadNextApplication.h"
 #include "ai/CredentialStore.h"
 #include "ai/LlmHttpClient.h"
@@ -56,7 +55,7 @@ EditScheduledTaskDialog::EditScheduledTaskDialog(const ScheduledTaskDefinition &
     , m_original(def)
 {
     setWindowTitle(def.id.isEmpty() ? tr("Add Scheduled Task") : tr("Edit Scheduled Task"));
-    resize(520, 700);
+    resize(520, 480);
 
     auto *mainLayout = new QVBoxLayout(this);
     auto *form = new QFormLayout();
@@ -131,27 +130,25 @@ EditScheduledTaskDialog::EditScheduledTaskDialog(const ScheduledTaskDefinition &
     mainLayout->addLayout(form);
 
     // Goal section
+    auto *goalRow = new QHBoxLayout();
     m_goalCheck = new QCheckBox(tr("Enable Goal Agent evaluation"), this);
     m_goalCheck->setChecked(def.hasGoalConfig);
-    mainLayout->addWidget(m_goalCheck);
-
-    m_goalGroup = new QGroupBox(tr("Goal Configuration"), this);
-    auto *goalGroupLayout = new QVBoxLayout(m_goalGroup);
-    goalGroupLayout->setContentsMargins(6, 6, 6, 6);
-    m_goalConfig = new GoalConfigWidget(agentRegistry, settings, m_goalGroup);
-    goalGroupLayout->addWidget(m_goalConfig);
-
-    if (def.hasGoalConfig) {
-        m_goalConfig->setCriteria(def.goalConfig.criteriaList);
-        m_goalConfig->setAgentId(def.goalConfig.agentId);
-        m_goalConfig->setMaxIterations(def.goalConfig.maxIterations);
-        if (!def.goalConfig.promptTemplateId.isEmpty())
-            m_goalConfig->setPromptTemplateId(def.goalConfig.promptTemplateId);
-    }
-
-    mainLayout->addWidget(m_goalGroup);
-    m_goalGroup->setVisible(def.hasGoalConfig);
-    connect(m_goalCheck, &QCheckBox::toggled, m_goalGroup, &QGroupBox::setVisible);
+    goalRow->addWidget(m_goalCheck);
+    m_goalConfigBtn = new QPushButton(tr("Configure..."), this);
+    m_goalConfigBtn->setEnabled(def.hasGoalConfig);
+    goalRow->addWidget(m_goalConfigBtn);
+    goalRow->addStretch();
+    mainLayout->addLayout(goalRow);
+
+    if (def.hasGoalConfig)
+        m_goalConfigData = def.goalConfig;
+
+    connect(m_goalCheck, &QCheckBox::toggled, m_goalConfigBtn, &QPushButton::setEnabled);
+    connect(m_goalConfigBtn, &QPushButton::clicked, this, [this]() {
+        GoalAgentConfigDialog dlg(m_goalConfigData, m_agentRegistry, m_settings, this);
+        if (dlg.exec() == QDialog::Accepted)
+            m_goalConfigData = dlg.goalConfig();
+    });
 
     // Buttons
     auto *btnLayout = new QHBoxLayout();
@@ -247,11 +244,7 @@ ScheduledTaskDefinition EditScheduledTaskDialog::taskResult() const
 
     def.hasGoalConfig = m_goalCheck->isChecked();
     if (def.hasGoalConfig) {
-        const GoalConfigResult gcr = m_goalConfig->result();
-        def.goalConfig.criteriaList = gcr.criteriaList;
-        def.goalConfig.agentId = gcr.agentId;
-        def.goalConfig.maxIterations = gcr.maxIterations;
-        def.goalConfig.promptTemplateId = gcr.promptTemplateId;
+        def.goalConfig = m_goalConfigData;
     } else {
         def.goalConfig = ScheduledTaskGoalConfig{};
     }
@@ -315,11 +308,16 @@ void EditScheduledTaskDialog::onCronHelperClicked()
     req.maxTokens = 50;
     req.idleTimeoutSec = 30;
 
+    m_cronHelperBtn->setEnabled(false);
+    m_cronHelperBtn->setText(tr("..."));
+
     auto *accumulated = new QString();
     connect(client, &ai::ILlmHttpClient::tokenReceived, this, [accumulated](const QString &token) {
         *accumulated += token;
     });
     connect(client, &ai::ILlmHttpClient::streamEnded, this, [this, client, accumulated]() {
+        m_cronHelperBtn->setEnabled(true);
+        m_cronHelperBtn->setText(tr("AI"));
         const QString cronExpr = accumulated->trimmed();
         auto parsed = CronExpression::parse(cronExpr);
         if (parsed && parsed->isValid()) {
@@ -332,6 +330,8 @@ void EditScheduledTaskDialog::onCronHelperClicked()
         client->deleteLater();
     });
     connect(client, &ai::ILlmHttpClient::errorOccurred, this, [this, client, accumulated](int, const QString &msg) {
+        m_cronHelperBtn->setEnabled(true);
+        m_cronHelperBtn->setText(tr("AI"));
         QMessageBox::warning(this, tr("AI Error"), msg);
         delete accumulated;
         client->deleteLater();

src/dialogs/EditScheduledTaskDialog.h

@@ -25,10 +25,8 @@
 
 class AcpAgentRegistry;
 class ApplicationSettings;
-class GoalConfigWidget;
 class QCheckBox;
 class QComboBox;
-class QGroupBox;
 class QLabel;
 class QLineEdit;
 class QPlainTextEdit;
@@ -82,8 +80,8 @@ private slots:
 
     // Goal section
     QCheckBox *m_goalCheck;
-    QGroupBox *m_goalGroup;
-    GoalConfigWidget *m_goalConfig;
+    QPushButton *m_goalConfigBtn;
+    ScheduledTaskGoalConfig m_goalConfigData;
 
     QPushButton *m_saveBtn;
 };

src/dialogs/GoalAgentConfigDialog.cpp

@@ -0,0 +1,65 @@
+/*
+ * This file is part of Notepad Next.
+ * Copyright 2026 NotepadAI contributors
+ *
+ * Notepad Next is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Notepad Next is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Notepad Next.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+#include "GoalAgentConfigDialog.h"
+
+#include <QDialogButtonBox>
+#include <QVBoxLayout>
+
+#include "GoalConfigWidget.h"
+
+GoalAgentConfigDialog::GoalAgentConfigDialog(const ScheduledTaskGoalConfig &config,
+                                             AcpAgentRegistry *registry,
+                                             ApplicationSettings *settings,
+                                             QWidget *parent)
+    : QDialog(parent)
+{
+    setWindowTitle(tr("Goal Configuration"));
+    setMinimumWidth(480);
+
+    auto *layout = new QVBoxLayout(this);
+    layout->setSpacing(8);
+
+    m_goalConfig = new GoalConfigWidget(registry, settings, this);
+    layout->addWidget(m_goalConfig);
+
+    if (!config.criteriaList.isEmpty())
+        m_goalConfig->setCriteria(config.criteriaList);
+    if (!config.agentId.isEmpty())
+        m_goalConfig->setAgentId(config.agentId);
+    if (config.maxIterations > 0)
+        m_goalConfig->setMaxIterations(config.maxIterations);
+    if (!config.promptTemplateId.isEmpty())
+        m_goalConfig->setPromptTemplateId(config.promptTemplateId);
+
+    auto *buttons = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this);
+    connect(buttons, &QDialogButtonBox::accepted, this, &QDialog::accept);
+    connect(buttons, &QDialogButtonBox::rejected, this, &QDialog::reject);
+    layout->addWidget(buttons);
+}
+
+ScheduledTaskGoalConfig GoalAgentConfigDialog::goalConfig() const
+{
+    ScheduledTaskGoalConfig cfg;
+    const auto gcr = m_goalConfig->result();
+    cfg.criteriaList = gcr.criteriaList;
+    cfg.agentId = gcr.agentId;
+    cfg.maxIterations = gcr.maxIterations;
+    cfg.promptTemplateId = gcr.promptTemplateId;
+    return cfg;
+}

src/dialogs/GoalAgentConfigDialog.h

@@ -0,0 +1,46 @@
+/*
+ * This file is part of Notepad Next.
+ * Copyright 2026 NotepadAI contributors
+ *
+ * Notepad Next is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Notepad Next is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Notepad Next.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+#ifndef GOAL_AGENT_CONFIG_DIALOG_H
+#define GOAL_AGENT_CONFIG_DIALOG_H
+
+#include <QDialog>
+
+#include "ScheduledTaskDefinition.h"
+
+class AcpAgentRegistry;
+class ApplicationSettings;
+class GoalConfigWidget;
+
+class GoalAgentConfigDialog : public QDialog
+{
+    Q_OBJECT
+
+public:
+    explicit GoalAgentConfigDialog(const ScheduledTaskGoalConfig &config,
+                                   AcpAgentRegistry *registry,
+                                   ApplicationSettings *settings,
+                                   QWidget *parent = nullptr);
+
+    ScheduledTaskGoalConfig goalConfig() const;
+
+private:
+    GoalConfigWidget *m_goalConfig;
+};
+
+#endif // GOAL_AGENT_CONFIG_DIALOG_H

src/dialogs/ScheduledTaskDialog.cpp

@@ -53,7 +53,10 @@ ScheduledTaskDialog::ScheduledTaskDialog(ScheduledTaskRegistry *registry,
     m_table = new QTableWidget(this);
     m_table->setColumnCount(4);
     m_table->setHorizontalHeaderLabels({tr("Enabled"), tr("Name"), tr("Cron"), tr("Next Fire")});
-    m_table->horizontalHeader()->setStretchLastSection(true);
+    m_table->horizontalHeader()->setSectionResizeMode(0, QHeaderView::ResizeToContents);
+    m_table->horizontalHeader()->setSectionResizeMode(1, QHeaderView::Stretch);
+    m_table->horizontalHeader()->setSectionResizeMode(2, QHeaderView::ResizeToContents);
+    m_table->horizontalHeader()->setSectionResizeMode(3, QHeaderView::ResizeToContents);
     m_table->setSelectionBehavior(QAbstractItemView::SelectRows);
     m_table->setSelectionMode(QAbstractItemView::SingleSelection);
     m_table->setEditTriggers(QAbstractItemView::NoEditTriggers);
@@ -198,6 +201,4 @@ void ScheduledTaskDialog::refreshTable()
         }
         m_table->setItem(i, 3, new QTableWidgetItem(nextStr));
     }
-
-    m_table->resizeColumnsToContents();
 }