fix(ai): wire images into prompt improver and fix diff palette

- PromptImprover::trigger now accepts images and enforces a 10 MB
  budget, emitting imagesBudgeted when images are dropped; callers
  use peekAll() so attachments survive the improve round-trip
- LlmHttpClient::buildPayload emits multipart content array when
  images are present, embedding base64 data-URIs with detail=low
- Diff palette dark canvasBg/Fg now matches the editor's own
  defaultBack/Fore so the diff canvas blends seamlessly; bgGutter
  added to both palettes to fix inverted gutter colors after theme
  transitions
- applyDiffStyles extracted so EditorManager's lexerChanged handler
  can skip diff views rather than overwriting the diff palette with
  the chrome theme's defaultBack
- openFolderAsWorkspacePath resolves relative paths to absolute
  before storing in the recent list or passing to QFileSystemModel,
  preventing "." from leaking into persisted state
- AiAgentDock minimum width bumped to 600 to accommodate image
  thumbnails without clipping

Author: nullmastermind

src/EditorManager.cpp

@@ -296,6 +296,10 @@ void EditorManager::setupEditor(ScintillaNext *editor)
     // applied (lexerChanged is emitted *after* SetLanguage from
     // NotepadNextApplication::setEditorLanguage) so dark mode survives.
     connect(editor, &ScintillaNext::lexerChanged, this, [this, editor]() {
+        // Diff views own their palette (GitDiffPainter); the chrome theme's
+        // defaultBack does not match canvasBg, so applying it would corrupt
+        // the diff colors until the next configureEditor call.
+        if (isDiffView(editor)) return;
         applyThemeToEditor(editor, darkTheme, /*initialSetup=*/false);
     });
 
@@ -372,17 +376,23 @@ void EditorManager::setupEditor(ScintillaNext *editor)
         JustfileRecipeHighlighter *jrh = new JustfileRecipeHighlighter(editor);
         jrh->setEnabled(true);
 
-        GitGutterDecorator *gg = new GitGutterDecorator(editor);
-        gg->setEnabled(gitGutterEnabled);
+        const bool isDiff = isDiffView(editor);
 
-        InlineBlameDecorator *blame = new InlineBlameDecorator(editor);
-        blame->setEnabled(inlineBlameEnabled);
-        connect(blame, &InlineBlameDecorator::commitClicked,
-                this, &EditorManager::blameCommitClicked);
+        GitGutterDecorator *gg = nullptr;
+        InlineBlameDecorator *blame = nullptr;
+        if (!isDiff) {
+            gg = new GitGutterDecorator(editor);
+            gg->setEnabled(gitGutterEnabled);
+
+            blame = new InlineBlameDecorator(editor);
+            blame->setEnabled(inlineBlameEnabled);
+            connect(blame, &InlineBlameDecorator::commitClicked,
+                    this, &EditorManager::blameCommitClicked);
+        }
 
         // Defer git decorator refreshes further so the deferred batch
         // itself doesn't block on QProcess spawns.
-        if (isFile) {
+        if (isFile && !isDiff) {
             QTimer::singleShot(0, editor, [gg, blame, gitGutterEnabled, inlineBlameEnabled]() {
                 if (gitGutterEnabled) gg->refresh();
                 if (inlineBlameEnabled) blame->refresh();
@@ -405,6 +415,14 @@ void EditorManager::applyTheme(bool dark)
     for (auto &editor : getEditors()) {
         if (!editor) continue;
 
+        // Diff views own their palette via GitDiffPainter::configureEditor and
+        // are re-skinned by GitDiffViewController::setDarkPalette on the
+        // effectiveThemeChanged signal. Running applyThemeToEditor on them
+        // would overwrite canvasBg/canvasFg with the chrome's defaultBack
+        // (visible as gray banding under the diff content) until the diff
+        // controller's slot fires next tick.
+        if (isDiffView(editor)) continue;
+
         if (transitionToLight) {
             // Coming from dark, where applyThemeToEditor lightened the lexer
             // foregrounds in-place. The original lexer-written values were

src/NotepadNextApplication.cpp

@@ -47,7 +47,9 @@
 
 #include <QCommandLineParser>
 
+#include <QDir>
 #include <QDirIterator>
+#include <QFileInfo>
 #include <QGuiApplication>
 #include <QPalette>
 #include <QStyle>
@@ -87,6 +89,27 @@ static QString toLocalFileName(const QString file)
     return fileUrl.isValid() && fileUrl.isLocalFile() ? fileUrl.toLocalFile() : file;
 }
 
+// Drop entries that can never be valid workspaces (empty, relative like ".",
+// or paths whose target directory no longer exists) and resolve any survivor
+// to its absolute form. Stale relative paths can land in App/RecentWorkspacesList
+// or FolderAsWorkspace/Workspaces from older builds that didn't normalize on
+// write — without this filter they'd keep showing up in the recent menu and
+// would re-spawn empty docks on session restore.
+static QStringList sanitizeWorkspacePaths(const QStringList &raw)
+{
+    QStringList out;
+    out.reserve(raw.size());
+    for (const QString &p : raw) {
+        if (p.isEmpty()) continue;
+        const QString abs = QDir(p).absolutePath();
+        if (abs.isEmpty()) continue;
+        if (!QFileInfo(abs).isDir()) continue;
+        if (out.contains(abs)) continue;
+        out.append(abs);
+    }
+    return out;
+}
+
 // Detect --new-window from raw argv before SingleApplication runs its primary-instance
 // check. When set we hand the base ctor a unique userData so this process gets its own
 // block-server identity and isn't intercepted as a secondary of the existing instance.
@@ -304,8 +327,9 @@ bool NotepadNextApplication::init()
         // key is no longer read or written.
         if (settings->value("FolderAsWorkspace/Workspaces").toStringList().isEmpty()) {
             const QString legacyRoot = settings->value("FolderAsWorkspace/RootPath").toString();
-            if (!legacyRoot.isEmpty()) {
-                settings->setValue("FolderAsWorkspace/Workspaces", QStringList{legacyRoot});
+            const QStringList sanitized = sanitizeWorkspacePaths(QStringList{legacyRoot});
+            if (!sanitized.isEmpty()) {
+                settings->setValue("FolderAsWorkspace/Workspaces", sanitized);
             }
         }
 
@@ -670,7 +694,8 @@ void NotepadNextApplication::openFiles(const QStringList &files)
 void NotepadNextApplication::loadSettings()
 {
     recentFilesListManager->setFileList(getSettings()->value("App/RecentFilesList").toStringList());
-    recentWorkspacesListManager->setFileList(getSettings()->value("App/RecentWorkspacesList").toStringList());
+    recentWorkspacesListManager->setFileList(
+        sanitizeWorkspacePaths(getSettings()->value("App/RecentWorkspacesList").toStringList()));
 }
 
 void NotepadNextApplication::saveSettings()

src/ai/ILlmHttpClient.h

@@ -20,8 +20,10 @@
 #define AI_I_LLM_HTTP_CLIENT_H
 
 #include <QObject>
+#include <QPair>
 #include <QString>
 #include <QUrl>
+#include <QVector>
 
 namespace ai {
 
@@ -40,6 +42,7 @@ class ILlmHttpClient : public QObject
         QString prompt;          // already-assembled full prompt (user role)
         int     maxTokens = 0;   // 0 = omit from payload (provider default)
         int     idleTimeoutSec = 60;
+        QVector<QPair<QByteArray, QString>> images;
     };
 
     explicit ILlmHttpClient(QObject *parent = nullptr) : QObject(parent) {}

src/ai/LlmHttpClient.cpp

@@ -59,7 +59,28 @@ QByteArray LlmHttpClient::buildPayload(const Request &req)
 
     QJsonObject userMsg;
     userMsg.insert(QLatin1String("role"),    QLatin1String("user"));
-    userMsg.insert(QLatin1String("content"), req.prompt);
+    if (req.images.isEmpty()) {
+        userMsg.insert(QLatin1String("content"), req.prompt);
+    } else {
+        QJsonArray contentArr;
+        QJsonObject textPart;
+        textPart.insert(QLatin1String("type"), QLatin1String("text"));
+        textPart.insert(QLatin1String("text"), req.prompt);
+        contentArr.append(textPart);
+        for (const auto &img : req.images) {
+            QJsonObject urlObj;
+            urlObj.insert(QLatin1String("url"),
+                          QStringLiteral("data:%1;base64,%2")
+                              .arg(img.second,
+                                   QString::fromLatin1(img.first.toBase64())));
+            urlObj.insert(QLatin1String("detail"), QLatin1String("low"));
+            QJsonObject imgPart;
+            imgPart.insert(QLatin1String("type"), QLatin1String("image_url"));
+            imgPart.insert(QLatin1String("image_url"), urlObj);
+            contentArr.append(imgPart);
+        }
+        userMsg.insert(QLatin1String("content"), contentArr);
+    }
     messages.append(userMsg);
 
     QJsonObject body;

src/ai/PromptImprover.cpp

@@ -82,7 +82,8 @@ bool PromptImprover::canImprove(QString *whyNot) const
 void PromptImprover::trigger(const QString &userDraft,
                              const QString &workingDirectory,
                              const QList<AcpProtocol::AcpCommandInfo> &commands,
-                             const QString &chatHistory)
+                             const QString &chatHistory,
+                             const QVector<QPair<QByteArray, QString>> &images)
 {
     QString why;
     if (!canImprove(&why)) {
@@ -101,7 +102,20 @@ void PromptImprover::trigger(const QString &userDraft,
     }
 
     const QString rules = loadRules(workingDirectory);
-    const QString systemPrompt = buildSystemPrompt(rules, commands);
+
+    constexpr qint64 kImageBudget = 10LL * 1024 * 1024;
+    QVector<QPair<QByteArray, QString>> budgetedImages;
+    qint64 totalBytes = 0;
+    for (const auto &img : images) {
+        if (totalBytes + img.first.size() > kImageBudget) break;
+        budgetedImages.append(img);
+        totalBytes += img.first.size();
+    }
+    if (budgetedImages.size() < images.size()) {
+        emit imagesBudgeted(budgetedImages.size(), images.size());
+    }
+
+    const QString systemPrompt = buildSystemPrompt(rules, commands, budgetedImages.size());
 
     m_responseBuffer.clear();
 
@@ -119,6 +133,7 @@ void PromptImprover::trigger(const QString &userDraft,
     req.prompt = userMessage;
     req.maxTokens = 4096;
     req.idleTimeoutSec = m_settings->commitMessageStreamIdleTimeoutSec();
+    req.images = budgetedImages;
 
     setState(State::Streaming);
     m_http->openStream(req);
@@ -172,10 +187,21 @@ void PromptImprover::onStreamError(int httpStatus, const QString &message)
 
 QString PromptImprover::buildSystemPrompt(
     const QString &rules,
-    const QList<AcpProtocol::AcpCommandInfo> &commands) const
+    const QList<AcpProtocol::AcpCommandInfo> &commands,
+    int imageCount) const
 {
     QString prompt = kSystemTemplate;
 
+    if (imageCount > 0) {
+        prompt += QStringLiteral(
+            "- The user has attached %1 image(s) alongside their draft. Examine the "
+            "visual content and incorporate what you see into the improved prompt — "
+            "reference specific UI elements, layouts, errors, or details visible in "
+            "the images to make the prompt more concrete. Do not narrate what you see "
+            "in the images; weave their context into the rewritten prompt naturally.\n")
+            .arg(imageCount);
+    }
+
     if (!rules.isEmpty()) {
         prompt += QStringLiteral("\n<project_rules>\n%1\n</project_rules>\n").arg(rules);
     }

src/ai/PromptImprover.h

@@ -2,8 +2,10 @@
 #define AI_PROMPT_IMPROVER_H
 
 #include <QObject>
+#include <QPair>
 #include <QString>
 #include <QList>
+#include <QVector>
 
 #include <cstdint>
 
@@ -35,14 +37,16 @@ class PromptImprover : public QObject
     void trigger(const QString &userDraft,
                  const QString &workingDirectory,
                  const QList<AcpProtocol::AcpCommandInfo> &commands,
-                 const QString &chatHistory = {});
+                 const QString &chatHistory = {},
+                 const QVector<QPair<QByteArray, QString>> &images = {});
 
     void cancel();
 
 signals:
     void stateChanged(ai::PromptImprover::State state);
     void finished(const QString &improvedText);
     void errorOccurred(const QString &message);
+    void imagesBudgeted(int sent, int total);
 
 private slots:
     void onFirstByte();
@@ -53,7 +57,8 @@ private slots:
 private:
     void setState(State s);
     QString buildSystemPrompt(const QString &rules,
-                              const QList<AcpProtocol::AcpCommandInfo> &commands) const;
+                              const QList<AcpProtocol::AcpCommandInfo> &commands,
+                              int imageCount) const;
     QString loadRules(const QString &workingDirectory) const;
     QString serializeCommands(const QList<AcpProtocol::AcpCommandInfo> &commands) const;
     QString parseImprovedPrompt(const QString &response) const;