Speed up Websock receive queue reads via DataView #2024
+23
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
core/websock.js:_rQshift()with a DataView-backed fast path for 1/2/4 byte reads to cut CPU time in the receive queue.Performance Summary
Average speed-up = mean reduction in the 1/2/4-byte benchmark cases (higher is better).
Testing
Benchmark Results
Windows Chrome 142
Windows Chrome 142(Machine 2)
Windows Chrome 101
Windows Chrome 92.0
Windows Chrome 83.0
Windows Chrome 71.0
Windows Edge 142
Windows Edge 142(Machine 2)
Windows Firefox 113
Windows Firefox 142
Windows Firefox 145.0
Safari 18
Karma Test
Can I use
https://caniuse.com/mdn-javascript_builtins_dataview