feat(tests): move from karma to vite #2016
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NefixEstrada
force-pushed
the
move-away-from-karma
branch
from
45bea1e to
25b6703
Compare
NefixEstrada
force-pushed
the
move-away-from-karma
branch
from
25b6703 to
e0326c8
Compare
Member
|
This is a bit more than just replacing Karma, if I understand things correctly. This also replaces Mocha, Chai and Sinon with vitest? That requires a bit more consideration if we want to replace all of those familiar components and become fully dependent on a single one. |
Author
|
Yes, this would change all the tecnologies to vitest. However:
There's a comparison in the vitest docs: https://vitest.dev/guide/comparisons.html#mocha Let me know if there's anything I can do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1883
There are 3 tests that now fail. Other than the performance one, I'm not sure the others are ok, maybe they were already failing? They're marked with a
TODO.I wasn't able to run the tests using karma
Please, let me know if there's something that I'm missing!