quic|blob: Potentially improve createBlobReaderStream performance

[martenrichter]

I am currently looking at the quic implementation code (in order to use it for webtransport).
I have seen that the quic implementation uses createBlobReaderStream

node/lib/internal/blob.js

Line 435 in 6f941fc

function createBlobReaderStream(reader) {

for getting the readable.

I am wondering createBlobReaderStream recreates functions for every call to pull.
My experience with webstreams in the browser (also using V8) suggests that this potentially creates a large number of function objects on the stack.
So I wonder, if it is not better to move readNext up to the top closure of the function and pass the controller as an argument.
This may be important, if you run for example a video stream over a webtransport stream.

Or am I am missing something?

[github-actions]

This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

[martenrichter]

@jasnell
That is probably something, that can be revisited. Though I do not know, if you have already addressed it. In my previous PR I added some data coalescing.