Skip to content

Commit 613656c

Browse files
committed
fixup! tools: add benchmark runner to test-shared
1 parent 4865f62 commit 613656c

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

.github/workflows/test-shared.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,17 @@ jobs:
160160
-- ${{ inputs.category }} \
161161
| tee /dev/stderr \
162162
> ${{ matrix.system }}.csv
163+
echo "Warning: do not take GHA benchmark results as face value, always confirm them"
164+
echo "using a dedicated machine, e.g. Jenkins CI."
165+
echo
163166
echo "Benchmark results:"
164167
echo
165168
echo '"'"'```'"'"'
166169
Rscript benchmark/compare.R < ${{ matrix.system }}.csv
167170
echo '"'"'```'"'"'
171+
echo
172+
echo "Warning: do not take GHA benchmark results as face value, always confirm them"
173+
echo "using a dedicated machine, e.g. Jenkins CI."
168174
' | tee /dev/stderr >> "$GITHUB_STEP_SUMMARY"
169175
env:
170176
FILTER: ${{ inputs.filter }}
@@ -213,9 +219,15 @@ jobs:
213219
--arg sharedLibDeps '{}' \
214220
--arg devTools '[]' \
215221
--run '
222+
echo "Warning: do not take GHA benchmark results as face value, always confirm them"
223+
echo "using a dedicated machine, e.g. Jenkins CI."
224+
echo
216225
echo "Benchmark results:"
217226
echo
218227
echo '"'"'```'"'"'
219228
awk "FNR==1 && NR!=1{next;}{print}" raw-results/*.csv | Rscript benchmark/compare.R
220229
echo '"'"'```'"'"'
230+
echo
231+
echo "Warning: do not take GHA benchmark results as face value, always confirm them"
232+
echo "using a dedicated machine, e.g. Jenkins CI."
221233
' | tee /dev/stderr >> "$GITHUB_STEP_SUMMARY"

shell.nix

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@
4646
pkgs.rPackages.ggplot2
4747
pkgs.rPackages.plyr
4848
pkgs.wrk
49-
] ++ pkgs.lib.optional pkgs.stdenv.buildPlatform.isLinux pkgs.glibcLocales,
49+
]
50+
++ pkgs.lib.optional pkgs.stdenv.buildPlatform.isLinux pkgs.glibcLocales,
5051
extraConfigFlags ? [
5152
"--without-npm"
5253
"--debug-node"

0 commit comments

Comments
 (0)