inspector,test: reject malformed initiator stack traces

Author: GrinZero

node.gyp

@@ -1418,6 +1418,7 @@
             # TODO(legendecas): make node_inspector.gypi a dependable target.
             '<(SHARED_INTERMEDIATE_DIR)', # for inspector
             '<(SHARED_INTERMEDIATE_DIR)/src', # for inspector
+            '<(SHARED_INTERMEDIATE_DIR)/inspector-generated-output-root/include',
           ],
           'dependencies': [
             'deps/inspector_protocol/inspector_protocol.gyp:crdtp',

src/inspector/network_agent.cc

@@ -167,7 +167,7 @@ NetworkAgent::createInitiatorFromObject(v8::Local<v8::Context> context,
         protocol::ValueConversions<v8_inspector::protocol::Runtime::API::
                                        StackTrace>::fromValue(stack_value.get(),
                                                               &errors);
-    if (!stack) {
+    if (!stack || !errors.Errors().empty()) {
       ThrowEventError(isolate, "Invalid initiator.stack in event");
       return {};
     }

test/cctest/inspector/test_node_protocol.cc

@@ -2,12 +2,22 @@
 #include "gtest/gtest.h"
 #include "inspector/node_json.h"
 #include "node/inspector/protocol/Protocol.h"
+#include "node/inspector/protocol/Runtime.h"
 
 namespace node {
 namespace inspector {
 namespace protocol {
 namespace {
 
+class MalformedSerializedValue : public Value {
+ public:
+  MalformedSerializedValue() : Value(TypeObject) {}
+
+  void AppendSerialized(std::vector<uint8_t>* out) const override {
+    out->push_back(0xff);
+  }
+};
+
 TEST(InspectorProtocol, Utf8StringSerDes) {
   constexpr const char* kKey = "unicode_key";
   constexpr const char* kValue = "CJK 汉字 🍱 🧑‍🧑‍🧒‍🧒";
@@ -27,6 +37,18 @@ TEST(InspectorProtocol, Utf8StringSerDes) {
   CHECK_EQ(parsed_value, std::string(kValue));
 }
 
+TEST(InspectorProtocol, StackTraceImportRejectsMalformedBinary) {
+  MalformedSerializedValue value;
+  ErrorSupport errors;
+
+  auto stack =
+      ValueConversions<v8_inspector::protocol::Runtime::API::StackTrace>::
+          fromValue(&value, &errors);
+
+  EXPECT_EQ(stack, nullptr);
+  EXPECT_FALSE(errors.Errors().empty());
+}
+
 }  // namespace
 }  // namespace protocol
 }  // namespace inspector