jenkins: append new job URL to existing CI comment

phillipj · phillipj · commit 0338bd3ed4ac · 2019-03-28T11:32:29.000+01:00
diff --git a/lib/push-jenkins-update.js b/lib/push-jenkins-update.js
@@ -26,7 +26,7 @@ function pushStarted (options, build, cb) {
       if (existingComment === undefined) {
         createPrComment(Object.assign({ number: pr }, options), body)
       } else {
-        editPrComment(options, existingComment.id, body)
+        editPrComment(options, existingComment.id, `${existingComment.body}\n${body}`)
       }
     })
   }
diff --git a/test/integration/push-jenkins-update.test.js b/test/integration/push-jenkins-update.test.js
@@ -140,7 +140,9 @@ tap.test('Edits existing CI comment when bot has posted a CI comment before', (t
 
   const editCommentScope = nock('https://api.github.com')
                         .filteringPath(ignoreQueryParams)
-                        .patch('/repos/nodejs/node/issues/comments/476584580', { body: 'CI: https://ci.nodejs.org/job/node-test-pull-request/21633/' })
+                        .patch('/repos/nodejs/node/issues/comments/476584580', {
+                          body: `CI: https://ci.nodejs.org/job/node-test-pull-request/21904/\nCI: https://ci.nodejs.org/job/node-test-pull-request/21633/`
+                        })
                         .reply(200)
 
   nock('https://api.github.com')

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ function pushStarted (options, build, cb) {`
`26`	`26`	`if (existingComment === undefined) {`
`27`	`27`	`createPrComment(Object.assign({ number: pr }, options), body)`
`28`	`28`	`} else {`
`29`		`- editPrComment(options, existingComment.id, body)`
	`29`	+ editPrComment(options, existingComment.id, `${existingComment.body}\n${body}`)
`30`	`30`	`}`
`31`	`31`	`})`
`32`	`32`	`}`