test: add cveId tests

Author: RafaelGSS

.github/workflows/test-and-release.yml

@@ -46,6 +46,8 @@ jobs:
   release:
     name: Release
     needs: test
+    permissions:
+      content: write
     runs-on: ubuntu-latest
     if: github.event_name == 'push' && github.ref == 'refs/heads/main'
     steps:

commit-to-output.js

@@ -39,9 +39,9 @@ export const formatType = {
 
 function toStringPlaintext (data) {
   let s = ''
+
   if (data.cveId) {
-    const pr = data.pr ? data.prUrl : ''
-    return ` * ${data.cveId} - ${data.summary.trim()} - ${pr}`
+    s += `(${data.cveId})`
   }
 
   s += (data.semver || []).length ? `(${data.semver.join(', ').toUpperCase()}) ` : ''
@@ -98,11 +98,7 @@ function toStringMarkdown (data) {
 }
 
 function toStringMessageOnly (data) {
-  let cveData
-  if (data.cveId) {
-    cveData = `${data.cveId} - `
-  }
-  return `  * ${cveData}${data.summary.trim()}`
+  return `  * ${data.cveId ? '(' + data.cveId + ') ' : ''}${data.summary.trim()}`
 }
 
 export function commitToOutput (commit, format, ghId, commitUrl) {

package.json

@@ -28,7 +28,7 @@
     "@octokit/graphql": "^7.0.1",
     "async": "^3.2.4",
     "chalk": "^5.3.0",
-    "commit-stream": "^2.1.0",
+    "commit-stream": "^2.2.0",
     "debug": "^4.3.4",
     "ghauth": "^6.0.0",
     "ghissues": "^1.1.4",

test.js

@@ -142,3 +142,12 @@ test('test find-matching-prs', (t) => {
 `)
   t.end()
 })
+
+test('test group, CVE-ID', (t) => {
+  const out = exec('--md --start-ref=43d428b3d2 --end-ref=43d428b3d2 --group --filter-release')
+  t.equal(
+    out,
+    `* \\[[\`43d428b3d2\`](https://github.com/nodejs/changelog-maker/commit/43d428b3d2)] - **(CVE-2024-22020)** **feat**: add cveId support to commmit output (RafaelGSS) [nodejs/node#55819](https://github.com/nodejs/node/pull/55819)
+`)
+  t.end()
+})