Now allows users with invalid tokens to access public resources

Author: jaxoncreed

lib/api/authn/webid-oidc.js

@@ -31,7 +31,16 @@ function initialize (app, argv) {
   app.use('/', middleware(oidc))
 
   // Perform the actual authentication
-  app.use('/', oidc.rs.authenticate())
+  app.use('/', async (req, res, next) => {
+    oidc.rs.authenticate()(req, res, (err) => {
+      // Error handling should be deferred to the ldp in case a user with a bad token is trying
+      // to access a public resource
+      if (err) {
+        req.authError = err
+      }
+      next()
+    })
+  })
 
   // Expose session.userId
   app.use('/', (req, res, next) => {

lib/handlers/allow.js

@@ -66,7 +66,7 @@ function allow (mode, checkPermissionsForDirectory) {
         }
       }
     }
-    const error = await req.acl.getError(userId, mode)
+    const error = req.authError || await req.acl.getError(userId, mode)
     debug(`${mode} access denied to ${userId || '(none)'}: ${error.status} - ${error.message}`)
     next(error)
   }