precondition if-none-match asterisk

Author: bourgeoa

lib/create-app.js

@@ -27,6 +27,7 @@ const { routeResolvedFile } = require('./utils')
 const ResourceMapper = require('./resource-mapper')
 const aclCheck = require('@solid/acl-check')
 const { version } = require('../package.json')
+// const preconditions = require('express-preconditions')
 
 const corsSettings = cors({
   methods: [

lib/handlers/put.js

@@ -64,10 +64,16 @@ async function putStream (req, res, next, stream = req) {
   try {
     // First check if the file already exists
     await ldp.resourceMapper.mapUrlToFile({ url: req })
+    // Fails on if-none-match asterisk precondition
+    if ((req.headers['if-none-match'] === '*') && !req.path.endsWith('/')) {
+      res.sendStatus(412)
+      return next()
+    }
   } catch (err) {
     resourceExists = false
   }
   try {
+    // Fails with Append on existing resource
     if (!req.originalUrl.endsWith('.acl')) await checkPermission(req, resourceExists)
     await ldp.put(req, stream, getContentType(req.headers))
     res.sendStatus(201)

test/integration/http-test.js

@@ -504,12 +504,20 @@ describe('HTTP APIs', function () {
       '../resources/sampleContainer/put1.ttl'), {
       encoding: 'utf8'
     })
-    it('should create new resource', function (done) {
+    it('should create new resource with if-none-match on non existing resource', function (done) {
       server.put('/put-resource-1.ttl')
         .send(putRequestBody)
+        .set('if-none-match', '*')
         .set('content-type', 'text/plain')
         .expect(201, done)
     })
+    it('should fail with 412 with precondition on existing resource', function (done) {
+      server.put('/put-resource-1.ttl')
+        .send(putRequestBody)
+        .set('if-none-match', '*')
+        .set('content-type', 'text/plain')
+        .expect(412, done)
+    })
     it('should fail with 400 if not content-type', function (done) {
       server.put('/put-resource-1.ttl')
         .send(putRequestBody)