fix: Activity is as:Add on Container POST

Notification emitted when a resource is created as a result of POST on a container has  activity type set to `as:Add`.

Author: CxRes

lib/handlers/notify.js

@@ -17,10 +17,13 @@ function getParent (path) {
   return parent === '/' ? '/' : `${parent}/`
 }
 
-function getActivity (method) {
+function getActivity (method, path) {
   if (method === 'DELETE') {
     return 'Delete'
   }
+  if (method === 'POST' && path.endsWith('/')) {
+    return 'Add'
+  }
   return 'Update'
 }
 
@@ -37,10 +40,10 @@ function getParentActivity (method, status) {
 function handler (req, res, next) {
   const { trigger, defaultNotification } = res.events.prep
 
-  const { method } = req
+  const { method, path } = req
   const { statusCode } = res
   const eventID = res.getHeader('event-id')
-  const fullUrl = new URL(req.path, `${req.protocol}://${req.hostname}/`)
+  const fullUrl = new URL(path, `${req.protocol}://${req.hostname}/`)
 
   // Date is a hack since node does not seem to provide access to send date.
   // Date needs to be shared with parent notification
@@ -56,10 +59,10 @@ function handler (req, res, next) {
           negotiatedFields
         ) {
           const mediaType = negotiatedFields['content-type']
-
+          const activity = getActivity(method, path)
           if (ALLOWED_RDF_MIME_TYPES.includes(mediaType?.[0])) {
             return `${headerTemplate(negotiatedFields)}\r\n${solidRDFTemplate({
-              activity: getActivity(method),
+              activity,
               eventID,
               object: String(fullUrl),
               date: eventDate,
@@ -81,7 +84,7 @@ function handler (req, res, next) {
 
   // Write a notification to parent container
   // POST in Solid creates a child resource
-  const parent = getParent(req.path)
+  const parent = getParent(path)
   if (parent && method !== 'POST') {
     try {
       const parentID = res.setEventID(parent)

test/integration/prep-test.js

@@ -142,7 +142,7 @@ solid:inserts { <u> <v> <z>. }.`
           expect(value.headers.get('content-type')).to.match(/application\/ld\+json/)
           const notification = await value.json()
           expect(notification).to.haveOwnProperty('published')
-          expect(notification.type).to.equal('Update')
+          expect(notification.type).to.equal('Add')
           expect(notification.object).to.match(/sampleContainer\/$/)
           controller.abort()
         })