Skip to content

chore: apply code review suggestions, qol changes#2

Open
PaddseL wants to merge 28 commits into
nicoprow:docs/company-certiciate-standard/updatefrom
PaddseL:docs/company-certiciate-standard/update
Open

chore: apply code review suggestions, qol changes#2
PaddseL wants to merge 28 commits into
nicoprow:docs/company-certiciate-standard/updatefrom
PaddseL:docs/company-certiciate-standard/update

Conversation

@PaddseL
Copy link
Copy Markdown

@PaddseL PaddseL commented Nov 10, 2025

Introduced changes:

  • Added missing certificate type examples
  • Added link to Industry Core: Basics reference in 4.1 NORMATIVE REFERENCES
  • Reintroduced Certificate Available notification
  • Fixed formatting of JSON examples
  • Fixed spelling of certificate type in examples
  • Fixed context references in openAPI yaml example
  • Removed unused schemas from openAPI yaml example
  • Fixed BpnLocation pattern in openAPI yaml example
  • Removed relatedMessageId attribute from the example payloads because it is optional
  • Adjusted Header in the openAPI yaml example to reuse the message header aspect model
  • Fixed formatting of openAPI yaml example
  • Reverted from Feedback notifications back to Status notifications to avoid introducing breaking changes
  • Reverted dct subject renaming for the CCMAPI asset to avoid introducing breaking changes
  • Formatting and QoL changes
  • Removed the sentence This request can be sent by the Certificate Consumer continuously, for updates on the request state on Certificate Provider side. as discussed in the meeting on 12.11.

@PaddseL PaddseL force-pushed the docs/company-certiciate-standard/update branch from b9434eb to a28e009 Compare November 11, 2025 07:55
@PaddseL PaddseL force-pushed the docs/company-certiciate-standard/update branch from 994ad3f to f401093 Compare November 11, 2025 08:30
@PaddseL PaddseL changed the title [wip] chore: apply code review suggestions, qol changes chore: apply code review suggestions, qol changes Nov 11, 2025
@PaddseL PaddseL marked this pull request as ready for review November 11, 2025 09:21
@PaddseL PaddseL force-pushed the docs/company-certiciate-standard/update branch from bd5c29c to 6f83c34 Compare November 12, 2025 09:57
@PaddseL PaddseL force-pushed the docs/company-certiciate-standard/update branch from 7b9dd6f to 46dfae7 Compare November 12, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant