Skip to content

feat(vcontact3): add vcontact3/prepareddatabases module#11738

Draft
olawal1001 wants to merge 5 commits into
nf-core:masterfrom
olawal1001:master
Draft

feat(vcontact3): add vcontact3/prepareddatabases module#11738
olawal1001 wants to merge 5 commits into
nf-core:masterfrom
olawal1001:master

Conversation

@olawal1001
Copy link
Copy Markdown

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@olawal1001 olawal1001 requested review from a team as code owners May 21, 2026 15:28
Copy link
Copy Markdown
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first start @olawal1001 !

Comments below :) Main thing is the meta.yaml documentation file has not yet been updated.

Comment thread nf-core/vcontact3/prepareddatabases/environment.yml Outdated
Comment thread nf-core/vcontact3/prepareddatabases/main.nf Outdated
Comment thread nf-core/vcontact3/prepareddatabases/main.nf Outdated
Comment thread nf-core/vcontact3/prepareddatabases/main.nf Outdated
--set-location "${prefix}" \\
$args

cat <<EOF > versions.yml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,77 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/nf-core/modules/master/modules/meta-schema.json
# # TODO nf-core: Add a description of the module and list keywords
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# # TODO nf-core: Add a description of the module and list keywords

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not seem updated from the boilerplate files, please replace/add content as necessary!

@jfy133 jfy133 marked this pull request as draft May 22, 2026 08:19
olawal1001 and others added 4 commits May 22, 2026 15:16
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants