feat(vcontact3): add vcontact3/prepareddatabases module#11738
Draft
olawal1001 wants to merge 5 commits into
Draft
feat(vcontact3): add vcontact3/prepareddatabases module#11738olawal1001 wants to merge 5 commits into
olawal1001 wants to merge 5 commits into
Conversation
jfy133
reviewed
May 22, 2026
Member
jfy133
left a comment
There was a problem hiding this comment.
Good first start @olawal1001 !
Comments below :) Main thing is the meta.yaml documentation file has not yet been updated.
| --set-location "${prefix}" \\ | ||
| $args | ||
|
|
||
| cat <<EOF > versions.yml |
Member
There was a problem hiding this comment.
This is the old method reporting versions, please instead use:
| @@ -0,0 +1,77 @@ | |||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/nf-core/modules/master/modules/meta-schema.json | |||
| # # TODO nf-core: Add a description of the module and list keywords | |||
Member
There was a problem hiding this comment.
Suggested change
| # # TODO nf-core: Add a description of the module and list keywords |
Member
There was a problem hiding this comment.
This file does not seem updated from the boilerplate files, please replace/add content as necessary!
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda