Skip to content

Update phasing and imputation sbwf#11731

Open
LouisLeNezet wants to merge 1 commit into
nf-core:masterfrom
LouisLeNezet:region_padding
Open

Update phasing and imputation sbwf#11731
LouisLeNezet wants to merge 1 commit into
nf-core:masterfrom
LouisLeNezet:region_padding

Conversation

@LouisLeNezet
Copy link
Copy Markdown
Contributor

@LouisLeNezet LouisLeNezet commented May 21, 2026

PR checklist

This PR solve two current issue in phaseimpute:

  • Early chunks have a regionout value with less numbers, throwing off the GLIMPSE_LIGATE sorting file.
    • solution: add 0 padding in front of regionout
  • Imputed chunks use groupTuple() that wait for all chunks to be imputed for all chromosomes.
    • solution: add regionSize key to register the number of chunks per chromosome and use it for grouping

No test was changed expect for the some stub as we need non null chunks for the tokenization to work.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this May 21, 2026
@LouisLeNezet LouisLeNezet requested a review from atrigila May 21, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant