New module: GRIMER#11663
Conversation
|
The stub test now uses an existing nf-core/test-datasets file to pass CI. I hope to add in a proper GRIMER-specific count table TSV to nf-core/test-datasets in a follow-up post-PR after review |
There was a problem hiding this comment.
Can you create this file on-the-fly within the nf.test please.
…add stub snapshot, revert .nf-core.yml
…meta.yml, update tests
|
Thanks for the latest comments @SPPearce! I've gone through everything and pushed some fixe *The metadata input in main.nf was tripping the linter since anything prefixed with meta gets treated as a Groovy map and renamed it to sample_metadata and that cleared it up |
|
Managed to fix the two GRIMER-specific CI failures in the latest push: *Version eval: The remaining CI failures ( |
|
The confirm-pass-lint gate failure is downstream of the multiqc and multiqcsav lint failures, which seems like pre-existing issues in those modules unrelated to this PR. The GRIMER module lint passes cleanly. I'm happy to have a reviewer confirm it |
You need to semi-regularly update the branch, so it only tests your changes, rather than unrelated other modules. |
SPPearce
left a comment
There was a problem hiding this comment.
Can you use the test file you are generating in the test currently with an actual run, not just a stub test, to get some output?
There was a problem hiding this comment.
This file is not required (and hasn't been for some time)
| script: | ||
| def args = task.ext.args ?: '' | ||
| def prefix = task.ext.prefix ?: "${meta.id}" | ||
| def m_arg = sample_metadata ? "-m ${sample_metadata}" : '' |
There was a problem hiding this comment.
| def m_arg = sample_metadata ? "-m ${sample_metadata}" : '' | |
| def m_arg = sample_metadata ? "-m ${sample_metadata}" : '' |
| [ | ||
| "GRIMER", | ||
| "grimer", | ||
| "bash: line 1: grimer: command not found" |
There was a problem hiding this comment.
This isn't correct ;)
Need to run the snapshot with a profile (docker/singularity/conda) that has the tool.
Closes #11566
Description
Adds a new nf-core module for GRIMER (v1.1.0), a tool that generates interactive HTML dashboards for contamination detection in metagenomics and viromics datasets.
Developed during the May 2026 nf-core x VirJenDB Virus Bioinformatics Hackathon.
Checklist
environment.ymlmatches bioconda packagemain.nfpasses lint (47/47 tests passed)meta.ymlcomplete and schema-valid