be more defensive, explain why POST /session fails

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

tests/integration/GithubOauthIntegrationTest.php

@@ -202,14 +202,18 @@ private function loginToGitHub(string $authorizeUrl): array {
 		$loginStatus = $loginResponse->getStatusCode();
 		$loginBody = $loginResponse->getBody()->getContents();
 
-		if ($loginStatus === Http::STATUS_OK && str_contains($loginBody, 'Two-factor authentication')) {
+		if ($loginStatus !== Http::STATUS_OK) {
+			$this->fail('GitHub login request to /session failed with status ' . $loginStatus . '. Response body: ' . $loginBody);
+		}
+
+		if (str_contains($loginBody, 'Two-factor authentication')) {
 			return [
 				'status' => '2fa_required',
 				'body' => $loginBody,
 			];
 		}
 
-		if ($loginStatus === Http::STATUS_OK && str_contains($loginBody, 'Incorrect username or password')) {
+		if (str_contains($loginBody, 'Incorrect username or password')) {
 			return [
 				'status' => 'invalid_credentials',
 				'body' => $loginBody,
@@ -251,7 +255,7 @@ private function handleAuthorizePage(string $authorizeUrl): string {
 		}
 
 		if (empty($formParams)) {
-			$this->fail('Could not find OAuth authorize form on page. The authorize page HTML may have changed or login did not succeed. Body: ' . $body);
+			$this->fail('Could not find OAuth authorize form on page. The authorize page HTML may have changed or login did not succeed. URL of the authorize page:' . $authorizeUrl . ' Body: ' . $body);
 		}
 
 		$authorizeResponse = $this->client->post('https://github.com/login/oauth/authorize', [
@@ -301,6 +305,7 @@ public function testOAuthLogin(): void {
 			$this->fail('Invalid GitHub credentials');
 		}
 
+		echo 'STATUS of login: ' . $loginResult['status'] . "\n\n";
 		$redirectUrl = null;
 		if ($loginResult['status'] === 'authorize_page' || $loginResult['status'] === 'logged_in') {
 			$redirectUrl = $this->handleAuthorizePage($authorizeUrl);