Skip to content

Commit 636c7fb

Browse files
authored
Merge pull request #539 from netwrix/dev
idioms and heading punctuation
2 parents d6f4543 + 9c1e3ce commit 636c7fb

5 files changed

Lines changed: 115 additions & 12 deletions

File tree

.claude/skills/doc-pr-fix/SKILL.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,19 @@ When editing:
9595
- Preserve the author's meaning and intent — fix the style, don't rewrite the content
9696
- Only change what was requested; don't fix other categories of issues even if they're on the same line (e.g., if asked to fix Vale issues, don't also fix Dale or editorial issues)
9797

98+
## Step 4b: Update the Vale Idioms rule
99+
100+
After applying fixes, check whether any Dale `idioms` violations or editorial items tagged `[idiom]` contained phrases not already in `.vale/styles/Netwrix/Idioms.yml`. For each new idiom:
101+
102+
1. Read `.vale/styles/Netwrix/Idioms.yml` to confirm the phrase isn't already covered (check for both exact matches and regex patterns that would match it).
103+
2. Add a new token entry under the most appropriate category comment. Follow existing conventions:
104+
- Use `\b` word boundaries for multi-word phrases.
105+
- Add optional inflection suffixes where the idiom can be conjugated (e.g., `\bgets? the ball rolling\b`).
106+
- Use single quotes around each token.
107+
3. Include the Idioms.yml file in your commit so the Vale rule grows over time.
108+
109+
If no new idioms were found, skip this step.
110+
98111
## Step 5: Verify
99112

100113
Review your edits to ensure they don't introduce new issues. Do NOT run Dale or any other skills during verification.

.claude/skills/doc-pr/SKILL.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,10 @@ For each issue found, note:
6060

6161
Only report issues on lines that were added or modified in this PR. Do not flag preexisting issues.
6262

63+
**Idiom tagging:** When the editorial review catches an idiom or figurative expression, tag it with `[idiom]` at the start of the bullet so the fixer can identify it and add it to the Vale `Idioms.yml` rule. Example:
64+
65+
- **Surface**[idiom] Line 42: "get the ball rolling" is an idiom. Suggested fix: "begin the process"
66+
6367
## Output — MANDATORY: Post as PR Comment
6468

6569
After completing both stages, you MUST write the review to a file and post it as a PR comment. This is the most important step — the review is useless if it is not posted.
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
extends: existence
2-
message: "Don't end headings with terminal punctuation ('%s'). Remove the trailing character."
2+
message: "Don't use punctuation in headings ('%s'). Rewrite the heading to remove it."
33
level: warning
44
scope: heading
55
nonword: true
66
tokens:
7-
- '\.$'
8-
- ':$'
9-
- ';$'
10-
- '\?$'
11-
- '!$'
7+
- '\.'
8+
- ':'
9+
- ';'
10+
- '\?'
11+
- '!'
12+
- '\('
13+
- '\)'

.vale/styles/Netwrix/HitVsClick.yml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.vale/styles/Netwrix/Idioms.yml

Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,90 @@
1+
extends: existence
2+
message: "Avoid the idiom '%s'. Write what you mean directly and literally."
3+
level: warning
4+
ignorecase: true
5+
tokens:
6+
# Overarching / scope idioms
7+
- 'tip of the iceberg'
8+
- 'at the end of the day'
9+
- '\bout of the box\b'
10+
- '\bout-of-the-box\b'
11+
- '\bin-the-box\b'
12+
- '\bunder the hood\b'
13+
- '\bin a nutshell\b'
14+
- '\bon the same page\b'
15+
- '\bfrom the ground up\b'
16+
- '\bbehind the scenes\b'
17+
- '\bout of the gate\b'
18+
- '\boff the beaten path\b'
19+
- '\bthe big picture\b'
20+
- '\bthe bottom line\b'
21+
22+
# Status / momentum idioms
23+
- '\bup and running\b'
24+
- '\bhit the ground running\b'
25+
- '\bramp(?:s|ed|ing)? up\b'
26+
- '\bspin(?:s|ning)? up\b'
27+
- '\bstand(?:s|ing)? up\b'
28+
- '\btear(?:s|ing)? down\b'
29+
- '\btore? down\b'
30+
31+
# Business/strategy jargon
32+
- '\blow.hanging fruit\b'
33+
- '\bmoves? the needle\b'
34+
- '\bboil(?:s|ed|ing)? the ocean\b'
35+
- '\blevels? the playing field\b'
36+
- '\braises? the bar\b'
37+
- '\bsets? the stage\b'
38+
- '\bpaves? the way\b'
39+
- '\bbridges? the gap\b'
40+
- '\bfills? the gap\b'
41+
- '\bcut(?:s|ting)? corners\b'
42+
- '\brule of thumb\b'
43+
- '\bacross the board\b'
44+
- '\bin the long run\b'
45+
- '\bin the same boat\b'
46+
47+
# Attention/awareness idioms
48+
- '\bkeep in mind\b'
49+
- '\bbear in mind\b'
50+
- '\bat your fingertips\b'
51+
- '\bon the radar\b'
52+
- '\bin the weeds\b'
53+
- '\bat first glance\b'
54+
- '\bby the same token\b'
55+
- '\bon the fly\b'
56+
57+
# Collaboration/process jargon
58+
- '\btouch(?:es|ing|ed)? base\b'
59+
- '\bcircle(?:s|d|ing)? back\b'
60+
- '\bloop(?:s|ed|ing)? in\b'
61+
- '\bflesh(?:es|ed|ing)? out\b'
62+
- '\biron(?:s|ed|ing)? out\b'
63+
- '\bhammer(?:s|ed|ing)? out\b'
64+
- '\bdrill(?:s|ed|ing)? down\b'
65+
- '\bzero(?:s|ed|ing)? in on\b'
66+
- '\bhone(?:s|d|ing)? in on\b'
67+
68+
# Deep dive variants
69+
- '\ba deep dive\b'
70+
- '\bdeep dive\b'
71+
- '\btake a deep dive\b'
72+
73+
# Work idioms
74+
- '\bfrom scratch\b'
75+
- '\bheavy lifting\b'
76+
- '\bpain points?\b'
77+
78+
# Tech marketing buzzwords
79+
- '\bgame.changer\b'
80+
- '\bsilver bullet\b'
81+
- '\bmagic bullet\b'
82+
- '\bone.stop.shop\b'
83+
- '\bbest of breed\b'
84+
- '\bbleeding.?edge\b'
85+
- '\bcutting.?edge\b'
86+
- '\bmission.critical\b'
87+
- '\bworld.class\b'
88+
- '\bturnkey\b'
89+
- '\bsynergy\b'
90+
- '\bleverage(?:s|d|ing)?\b'

0 commit comments

Comments
 (0)