Downgrade S2139 to suggestion

Author: neoscie

CHANGELOG.md

@@ -18,7 +18,6 @@ and adheres to a project-specific [Versioning](/README.md).
 
 ### Added
 
-- S2139: Exceptions should be either logged or rethrown but not both
 - S2629: Logging templates should be constant
 - S3431: "[ExpectedException]" should not be used
 - S4347: Secure random number generators should not output predictable values

build/Neolution.CodeAnalysis.globalconfig

@@ -282,6 +282,10 @@ dotnet_diagnostic.S6678.severity = suggestion
 ; This is handled by a custom model binder in our project templates that produces a bad request response in case of under-posting 
 dotnet_diagnostic.S6964.severity = none
 
+# S2139: Exceptions should be either logged or rethrown but not both
+; Although this rule makes sense, we do not want to enforce it
+dotnet_diagnostic.S2139.severity = suggestion
+
 # S107: Methods should not have too many parameters
 dotnet_diagnostic.S107.severity = warning