feat!: useLegacy is now default =>

* Your answer handling needs to be updated. `content` is now of type [HttpsResponseLegacy](https://github.com/farfromrefug/nativescript-https/blob/c7b8c935a6b02dc4f9e5c20c6911b2e59db8fa64/src/https.common.ts#L74)
* `useLegacy` is not a request option anymore it is now the second optional parameter to the [request](https://github.com/farfromrefug/nativescript-https/blob/c7b8c935a6b02dc4f9e5c20c6911b2e59db8fa64/src/https.d.ts#L7) method

Author: farfromrefug

src/https.android.ts

@@ -389,7 +389,7 @@ const notClosedResponses: {
 const runningClients: { [k: string]: okhttp3.OkHttpClient } = {};
 
 let OkHttpResponse: typeof com.nativescript.https.OkHttpResponse;
-export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsRequest {
+export function createRequest(opts: Https.HttpsRequestOptions, useLegacy: boolean = true): Https.HttpsRequest {
     const client = getClient(false, opts.timeout);
 
     const request = new okhttp3.Request.Builder();
@@ -468,7 +468,7 @@ export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsReque
     // We have to allow networking on the main thread because larger responses will crash the app with an NetworkOnMainThreadException.
     // Note that it would probably be better to offload it to a Worker or (natively running) AsyncTask.
     // Also note that once set, this policy remains active until the app is killed.
-    if (opts.useLegacy === false && opts.allowLargeResponse) {
+    if (useLegacy === false && opts.allowLargeResponse) {
         android.os.StrictMode.setThreadPolicy(android.os.StrictMode.ThreadPolicy.LAX);
     }
     return {
@@ -494,7 +494,7 @@ export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsReque
                             }
                             return headers;
                         };
-                        if (opts.useLegacy) {
+                        if (useLegacy) {
                             if (!OkHttpResponse) {
                                 OkHttpResponse = com.nativescript.https.OkHttpResponse;
                             }
@@ -538,10 +538,10 @@ export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsReque
     };
 }
 
-export function request(opts: Https.HttpsRequestOptions) {
+export function request(opts: Https.HttpsRequestOptions, useLegacy: boolean = true) {
     return new Promise((resolve, reject) => {
         try {
-            createRequest(opts).run(resolve, reject);
+            createRequest(opts, useLegacy).run(resolve, reject);
         } catch (error) {
             reject(error);
         }

src/https.common.ts

@@ -52,7 +52,6 @@ export interface HttpsRequestOptions extends HttpRequestOptions {
     onProgress?: (current: number, total: number) => void;
 
     cachePolicy?: CachePolicy;
-    useLegacy?: boolean;
 }
 
 export interface HttpsResponse<T = any> {
@@ -71,14 +70,14 @@ export interface HttpsRequest {
     run(success, failure);
 }
 
-export interface HttpsResponseLegacy {
+export interface HttpsResponseLegacy<T = any> {
     toArrayBuffer(): ArrayBuffer;
     toArrayBufferAsync(): Promise<ArrayBuffer>;
 
     toString(): string;
     toStringAsync(): Promise<string>;
-    toJSON(): any;
-    toJSONAsync(): Promise<any>;
+    toJSON(): T;
+    toJSONAsync(): Promise<T>;
     toImage(): Promise<ImageSource>;
     // toImageAsync(): Promise<ImageSource>;
     toFile(destinationFilePath: string): Promise<File>;

src/https.d.ts

@@ -4,7 +4,7 @@ export function enableSSLPinning(options: Https.HttpsSSLPinningOptions);
 
 export function disableSSLPinning();
 
-export function request<T = any>(options: Https.HttpsRequestOptions): Promise<Https.HttpsResponse<T>>;
+export function request<U extends boolean, T = any>(options: Https.HttpsRequestOptions, useLegacy?: U): U extends true ? Promise<Https.HttpsResponseLegacy<T>> : Promise<Https.HttpsResponse<T>>;
 export function setCache(options?: Https.CacheOptions);
 export function clearCache();
 export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsRequest;

src/https.ios.ts

@@ -306,7 +306,7 @@ export function cancelRequest(tag: string) {
     }
 }
 
-export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsRequest {
+export function createRequest(opts: Https.HttpsRequestOptions, useLegacy: boolean = true): Https.HttpsRequest {
     const type = opts.headers && opts.headers['Content-Type'] ? (opts.headers['Content-Type'] as string) : 'application/json';
     if (type.startsWith('application/json')) {
         manager.requestSerializer = AFJSONRequestSerializer.serializer();
@@ -356,12 +356,10 @@ export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsReque
 
     manager.requestSerializer.timeoutInterval = opts.timeout ? opts.timeout : 10;
 
-    const useLegacy = Utils.isDefined(opts.useLegacy) ? opts.useLegacy : false;
-
     const progress = opts.onProgress
         ? (progress: NSProgress) => {
-              opts.onProgress(progress.completedUnitCount, progress.totalUnitCount);
-          }
+            opts.onProgress(progress.completedUnitCount, progress.totalUnitCount);
+        }
         : null;
     let task: NSURLSessionDataTask;
     const tag = opts.tag;
@@ -473,10 +471,10 @@ export function createRequest(opts: Https.HttpsRequestOptions): Https.HttpsReque
         },
     };
 }
-export function request(opts: Https.HttpsRequestOptions) {
+export function request(opts: Https.HttpsRequestOptions, useLegacy: boolean = true) {
     return new Promise((resolve, reject) => {
         try {
-            createRequest(opts).run(resolve, reject);
+            createRequest(opts, useLegacy).run(resolve, reject);
         } catch (error) {
             reject(error);
         }