-
Notifications
You must be signed in to change notification settings - Fork 1.4k
improve body build documentation & images - increase nut count #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Achllle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
What are the ODG files for? I don't see them mentioned in the docs anywhere and I'm not familliar with that format.
|
They are libreoffice drawing files used to do the image annotations. Was
reading the OSHWA guide and we are supposed to:
"
The instructions could be in a variety of formats, like a wiki, text file,
Google Doc, or PDF. Remember, though, that others might want to modify your
instructions as they modify your hardware design, so it’s good to provide
the original editable files for your documentation, not just output formats
like PDF.
"
|
typo Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
|
I'd rather not add them because it makes the repo heavier and the images are fairly easy to reproduce. I'm mostly worried about changing the instructions and forgetting to update those files. |
fair enough. removed. |
Achllle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR adds step-by-step instructions & images for the body box build.
I also found that I didn't have enough M4 nuts, so I added a bag to the parts list.