Random bytes require cycle for SJCL and react-native-crypto

[Sheharyar566]

I created an empty project and installed react-native-randombytes. However, i'm getting a require cycle warning as

Require cycle: node_modules\react-native-randombytes\index.js -> node_modules\sjcl\sjcl.js -> node_modules\react-native-crypto\index.js -> node_modules\react-native-randombytes\index.js

To reproduce this, create an empty project and use randomBytes import from react-native-randomBytes.

[mvayngrib]

@Sheharyar566 as far as i know, this does not affect functionality. Does it break anything for you?

[Sheharyar566]

ah yup, there's this package named stanza which uses this package under the hood to generate a "resource" value. So when I use the imports from the package, I get two require cycles and an undefined log as

Require cycle: node_modules\react-native-randombytes\index.js -> node_modules\sjcl\sjcl.js -> node_modules\react-native-crypto\index.js -> node_modules\react-native-randombytes\index.js

Require cycle: node_modules\sjcl\sjcl.js -> node_modules\sjcl\sjcl.js

[TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[2], "sjcl").random.randomWords')]

Not sure if it's helpful tho but upon looking at the minified file, this is where it seems to be saying undefined

  function randomBytes(length, cb) {
    if (!cb) {
      var size = length;
      var wordCount = Math.ceil(size * 0.25);

      var _randomBytes = _$$_REQUIRE(_dependencyMap[2], "sjcl").random.randomWords(wordCount, 10);

      var hexString = _$$_REQUIRE(_dependencyMap[2], "sjcl").codec.hex.fromBits(_randomBytes);

      hexString = hexString.substr(0, size * 2);
      return new Buffer(hexString, 'hex');
    }