Merge pull request #97 from mujin/silence_zmq_bullseye

Silence ZMQ related warnings

Author: rdiankov

include/mujincontrollerclient/mujinjson.h

@@ -164,7 +164,7 @@ inline void ParseJson(rapidjson::Document& d, const std::string& str) {
 inline void ParseJson(rapidjson::Document& d, std::istream& is) {
     rapidjson::IStreamWrapper isw(is);
     // see note in: void ParseJson(rapidjson::Document& d, const std::string& str)
-    rapidjson::Document(tempDoc);
+    rapidjson::Document tempDoc;
     tempDoc.ParseStream<rapidjson::kParseFullPrecisionFlag>(isw); // parse float in full precision mode
     if (tempDoc.HasParseError()) {
         throw MujinJSONException(boost::str(boost::format("Json stream is invalid (offset %u) %s")%((unsigned)d.GetErrorOffset())%GetParseError_En(d.GetParseError())), MJE_Failed);

src/binpickingtask.cpp

@@ -1785,14 +1785,12 @@ void BinPickingTaskResource::_HeartbeatMonitorThread(const double reinitializeti
             socket.reset();
         }
         socket.reset(new zmq::socket_t((*_zmqcontext.get()),ZMQ_SUB));
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE, 1); // turn on tcp keepalive, do these configuration before connect
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE_IDLE, 2); // the interval between the last data packet sent (simple ACKs are not considered data) and the first keepalive probe; after the connection is marked to need keepalive, this counter is not used any further
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE_INTVL, 2); // the interval between subsequential keepalive probes, regardless of what the connection has exchanged in the meantime
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE_CNT, 2); // the number of unacknowledged probes to send before considering the connection dead and notifying the application layer
-        std::stringstream ss; ss << std::setprecision(std::numeric_limits<double>::digits10+1);
-        ss << _heartbeatPort;
-        socket->connect(("tcp://"+ _mujinControllerIp+":"+ss.str()).c_str());
-        socket->setsockopt(ZMQ_SUBSCRIBE, "", 0);
+        socket->set(zmq::sockopt::tcp_keepalive, 1); // turn on tcp keepalive, do these configuration before connect
+        socket->set(zmq::sockopt::tcp_keepalive_idle, 2); // the interval between the last data packet sent (simple ACKs are not considered data) and the first keepalive probe; after the connection is marked to need keepalive, this counter is not used any further
+        socket->set(zmq::sockopt::tcp_keepalive_intvl, 2); // the interval between subsequential keepalive probes, regardless of what the connection has exchanged in the meantime
+        socket->set(zmq::sockopt::tcp_keepalive_cnt, 2); // the number of unacknowledged probes to send before considering the connection dead and notifying the application layer
+        socket->connect("tcp://" +  _mujinControllerIp + ":" + std::to_string(_heartbeatPort));
+        socket->set(zmq::sockopt::subscribe, "");
 
         zmq::pollitem_t pollitem;
         memset(&pollitem, 0, sizeof(zmq::pollitem_t));
@@ -1801,13 +1799,12 @@ void BinPickingTaskResource::_HeartbeatMonitorThread(const double reinitializeti
 
         unsigned long long lastheartbeat = GetMilliTime();
         while (!_bShutdownHeartbeatMonitor && (GetMilliTime() - lastheartbeat) / 1000.0f < reinitializetimeout) {
-            zmq::poll(&pollitem,1, 50); // wait 50 ms for message
+            zmq::poll(&pollitem, 1, std::chrono::milliseconds{50}); // wait 50 ms for message
             if (pollitem.revents & ZMQ_POLLIN) {
                 zmq::message_t reply;
-                socket->recv(&reply);
-                std::string replystring((char *)reply.data (), (size_t)reply.size());
+                socket->recv(reply);
                 //if ((size_t)reply.size() == 1 && ((char *)reply.data())[0]==255) {
-                if (replystring == "255") {
+                if (reply.to_string() == "255") {
                     lastheartbeat = GetMilliTime();
                 }
             }
@@ -1827,37 +1824,36 @@ void BinPickingTaskResource::_HeartbeatMonitorThread(const double reinitializeti
 std::string utils::GetHeartbeat(const std::string& endpoint) {
     zmq::context_t zmqcontext(1);
     zmq::socket_t socket(zmqcontext, ZMQ_SUB);
-    socket.connect(endpoint.c_str());
-    socket.setsockopt(ZMQ_SUBSCRIBE, "", 0);
+    socket.connect(endpoint);
+    socket.set(zmq::sockopt::subscribe, "");
 
     zmq::pollitem_t pollitem;
     memset(&pollitem, 0, sizeof(zmq::pollitem_t));
     pollitem.socket = socket;
     pollitem.events = ZMQ_POLLIN;
 
-    zmq::poll(&pollitem,1, 50); // wait 50 ms for message
+    zmq::poll(&pollitem, 1, std::chrono::milliseconds{50}); // wait 50 ms for message
     if (!(pollitem.revents & ZMQ_POLLIN)) {
         return "";
     }
 
     zmq::message_t reply;
-    socket.recv(&reply);
-    const std::string received((char *)reply.data (), (size_t)reply.size());
+    socket.recv(reply);
 #ifndef _WIN32
-    return received;
+    return reply.to_string();
 #else
     // sometimes buffer can container \n or \\, which windows does not like
     std::string newbuffer;
     std::vector< std::pair<std::string, std::string> > serachpairs(2);
     serachpairs[0].first = "\n"; serachpairs[0].second = "";
     serachpairs[1].first = "\\"; serachpairs[1].second = "";
-    SearchAndReplace(newbuffer, received, serachpairs);
+    SearchAndReplace(newbuffer, reply.to_string(), serachpairs);
     return newbuffer;
 #endif
 }
 
-
 namespace {
+
 std::string FindSmallestSlaveRequestId(const rapidjson::Value& pt) {
     // get all slave request ids
     std::vector<std::string> slavereqids;
@@ -1898,13 +1894,11 @@ std::string FindSmallestSlaveRequestId(const rapidjson::Value& pt) {
     return slavereqids[smallest_suffix_index];
 }
 
-std::string GetValueForSmallestSlaveRequestId(const std::string& heartbeat,
-                                              const std::string& key)
+std::string GetValueForSmallestSlaveRequestId(const std::string& heartbeat, const std::string& key)
 {
 
     rapidjson::Document pt(rapidjson::kObjectType);
-    std::stringstream ss(heartbeat);
-    ParseJson(pt, ss.str());
+    ParseJson(pt, heartbeat);
     try {
         const std::string slavereqid = FindSmallestSlaveRequestId(pt);
         std::string result;
@@ -1916,8 +1910,8 @@ std::string GetValueForSmallestSlaveRequestId(const std::string& heartbeat,
     }
 
 }
-}
 
+} // anonymous namespace
 
 std::string mujinclient::utils::GetScenePkFromHeartbeat(const std::string& heartbeat) {
     static const std::string prefix("mujin:/");
@@ -1926,8 +1920,7 @@ std::string mujinclient::utils::GetScenePkFromHeartbeat(const std::string& heart
 
 std::string utils::GetSlaveRequestIdFromHeartbeat(const std::string& heartbeat) {
     rapidjson::Document pt;
-    std::stringstream ss(heartbeat);
-    ParseJson(pt, ss.str());
+    ParseJson(pt, heartbeat);
     try {
         static const std::string prefix("slaverequestid-");
         return FindSmallestSlaveRequestId(pt).substr(prefix.length());

src/binpickingtaskzmq.cpp

@@ -267,30 +267,26 @@ void BinPickingTaskZmqResource::_HeartbeatMonitorThread(const double reinitializ
             socket.reset();
         }
         socket.reset(new zmq::socket_t((*_zmqcontext.get()),ZMQ_SUB));
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE, 1); // turn on tcp keepalive, do these configuration before connect
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE_IDLE, 2); // the interval between the last data packet sent (simple ACKs are not considered data) and the first keepalive probe; after the connection is marked to need keepalive, this counter is not used any further
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE_INTVL, 2); // the interval between subsequential keepalive probes, regardless of what the connection has exchanged in the meantime
-        socket->setsockopt(ZMQ_TCP_KEEPALIVE_CNT, 2); // the number of unacknowledged probes to send before considering the connection dead and notifying the application layer
-        std::stringstream ss; ss << std::setprecision(std::numeric_limits<double>::digits10+1);
-        ss << _heartbeatPort;
-        socket->connect (("tcp://"+ _mujinControllerIp+":"+ss.str()).c_str());
-        socket->setsockopt(ZMQ_SUBSCRIBE, "", 0);
+        socket->set(zmq::sockopt::tcp_keepalive, 1); // turn on tcp keepalive, do these configuration before connect
+        socket->set(zmq::sockopt::tcp_keepalive_idle, 2); // the interval between the last data packet sent (simple ACKs are not considered data) and the first keepalive probe; after the connection is marked to need keepalive, this counter is not used any further
+        socket->set(zmq::sockopt::tcp_keepalive_intvl, 2); // the interval between subsequential keepalive probes, regardless of what the connection has exchanged in the meantime
+        socket->set(zmq::sockopt::tcp_keepalive_cnt, 2); // the number of unacknowledged probes to send before considering the connection dead and notifying the application layer
+        socket->connect("tcp://" +  _mujinControllerIp + ":" + std::to_string(_heartbeatPort));
+        socket->set(zmq::sockopt::subscribe, "");
 
         zmq::pollitem_t pollitem;
         memset(&pollitem, 0, sizeof(zmq::pollitem_t));
         pollitem.socket = socket->operator void*();
         pollitem.events = ZMQ_POLLIN;
         unsigned long long lastheartbeat = GetMilliTime();
         while (!_bShutdownHeartbeatMonitor && (GetMilliTime() - lastheartbeat) / 1000.0f < reinitializetimeout) {
-            zmq::poll(&pollitem,1, 50); // wait 50 ms for message
+            zmq::poll(&pollitem, 1, std::chrono::milliseconds{50}); // wait 50 ms for message
             if (pollitem.revents & ZMQ_POLLIN) {
                 zmq::message_t reply;
-                socket->recv(&reply);
-                std::string replystring((char *)reply.data (), (size_t)reply.size());
+                socket->recv(reply);
                 rapidjson::Document pt(rapidjson::kObjectType);
                 try{
-                    std::stringstream replystring_ss(replystring);
-                    ParseJson(pt, replystring_ss.str());
+                    ParseJson(pt, reply.to_string());
                     heartbeat.Parse(pt);
                     {
                         boost::mutex::scoped_lock lock(_mutexTaskState);
@@ -304,7 +300,7 @@ void BinPickingTaskZmqResource::_HeartbeatMonitorThread(const double reinitializ
                 }
                 catch (std::exception const &e) {
                     MUJIN_LOG_ERROR("HeartBeat reply is not JSON");
-                    MUJIN_LOG_ERROR(replystring);
+                    MUJIN_LOG_ERROR(reply.to_string());
                     MUJIN_LOG_ERROR(e.what());
                     continue;
                 }
@@ -319,6 +315,4 @@ void BinPickingTaskZmqResource::_HeartbeatMonitorThread(const double reinitializ
     MUJIN_LOG_DEBUG(str(boost::format("Stopped controller %s monitoring thread on port %d for slaverequestid=%s.")%_mujinControllerIp%_heartbeatPort%_slaverequestid));
 }
 
-
-
 } // end namespace mujinclient