Skip to content

Commit 2d70094

Browse files
authored
refactor: Reduce duplication of identity events (#87)
1 parent fb1e698 commit 2d70094

1 file changed

Lines changed: 11 additions & 16 deletions

File tree

src/Rokt-Kit.ts

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1104,33 +1104,28 @@ class RoktKit implements KitInterface {
11041104
return 'Successfully removed user attribute for forwarder: ' + name;
11051105
}
11061106

1107-
public onUserIdentified(user: IMParticleUser): string {
1107+
private handleIdentityComplete(user: IMParticleUser, eventType: RoktIdentityEventType, callbackName: string): string {
11081108
const filteredUser = user as FilteredUser;
1109-
this.filters.filteredUser = filteredUser;
11101109
this.userAttributes = user.getAllUserAttributes();
1111-
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.IDENTIFY, filteredUser));
1112-
return 'Successfully called onUserIdentified for forwarder: ' + name;
1110+
this.pendingIdentityEvents.push(this.buildIdentityEvent(eventType, filteredUser));
1111+
return 'Successfully called ' + callbackName + ' for forwarder: ' + name;
1112+
}
1113+
1114+
public onUserIdentified(user: IMParticleUser): string {
1115+
this.filters.filteredUser = user as FilteredUser;
1116+
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.IDENTIFY, 'onUserIdentified');
11131117
}
11141118

11151119
public onLoginComplete(user: IMParticleUser, _filteredIdentityRequest: unknown): string {
1116-
const filteredUser = user as FilteredUser;
1117-
this.userAttributes = user.getAllUserAttributes();
1118-
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.LOGIN, filteredUser));
1119-
return 'Successfully called onLoginComplete for forwarder: ' + name;
1120+
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.LOGIN, 'onLoginComplete');
11201121
}
11211122

11221123
public onLogoutComplete(user: IMParticleUser, _filteredIdentityRequest: unknown): string {
1123-
const filteredUser = user as FilteredUser;
1124-
this.userAttributes = user.getAllUserAttributes();
1125-
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.LOGOUT, filteredUser));
1126-
return 'Successfully called onLogoutComplete for forwarder: ' + name;
1124+
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.LOGOUT, 'onLogoutComplete');
11271125
}
11281126

11291127
public onModifyComplete(user: IMParticleUser, _filteredIdentityRequest: unknown): string {
1130-
const filteredUser = user as FilteredUser;
1131-
this.userAttributes = user.getAllUserAttributes();
1132-
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.MODIFY_USER, filteredUser));
1133-
return 'Successfully called onModifyComplete for forwarder: ' + name;
1128+
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.MODIFY_USER, 'onModifyComplete');
11341129
}
11351130

11361131
/**

0 commit comments

Comments
 (0)