Better error report management

Author: jecisc

src/FAST-Python-Tools-Tests/FASTPythonImporterTest.class.st

@@ -187,18 +187,22 @@ FASTPythonImporterTest >> importerClass [
 { #category : 'running' }
 FASTPythonImporterTest >> parse: aString [
 
-	^ fast := self importer parse: aString withPlatformLineEndings
+	^ fast := self importer
+		          errorReportBlock: [ :i | i errors ifNotEmpty: [ self fail: 'Errors happened during parsing. Errors: ' , i errors printString ] ];
+		          parse: aString withPlatformLineEndings
 ]
 
 { #category : 'private' }
 FASTPythonImporterTest >> performTest [
 	"If an error happens, dump the AST in the message text so that we can have an idea of what is the problem in the logs."
 
-	[ super performTest ]
+	"[ super performTest ]
 		on: Error
 		do: [ :failure |
 				fast ifNotNil: [ failure messageText: failure messageText , ' FASTDump: ' , (RBParser parseExpression: fast rootEntities anyOne dump) formattedCode ].
-				failure pass ]
+				failure pass ]"
+
+	super performTest
 ]
 
 { #category : 'running' }

src/FAST-Python-Tools/FASTPythonImporter.class.st

@@ -2,7 +2,8 @@ Class {
 	#name : 'FASTPythonImporter',
 	#superclass : 'Object',
 	#instVars : [
-		'tsParser'
+		'tsParser',
+		'errorReportBlock'
 	],
 	#category : 'FAST-Python-Tools',
 	#package : 'FAST-Python-Tools'
@@ -103,6 +104,12 @@ FASTPythonImporter >> deleteTreeSitterParser [
 	self tsParser delete
 ]
 
+{ #category : 'accessing' }
+FASTPythonImporter >> errorReportBlock: aBlock [
+
+	errorReportBlock := aBlock
+]
+
 { #category : 'as yet unclassified' }
 FASTPythonImporter >> initialiseTreeSitterParser [ 
 
@@ -119,6 +126,7 @@ FASTPythonImporter >> parse: aString [
 	tsTree := self tsParser parseString: aString.
 	fastTree := TSFASTPythonImporter new
 		            originString: aString;
+		            in: [ :importer | errorReportBlock ifNotNil: [ importer errorReportBlock: errorReportBlock ] ];
 		            import: tsTree rootNode.
 
 	self deleteTreeSitterParser.