log_level=0 does not completely disable logging

[jschueller]

currently pyfmi defaults to opening log file in the current dir by default when log_file_name=""
now I want to disable logs because the current directory is not writeable so I set log_level=0
but pyfmi still tries to open a log file
is this expected, or do we need another log level ?

cc @modelonrobinandersson @agnesramle, since you're working on streams

[modelonrobinandersson]

currently pyfmi defaults to opening log file in the current dir by default when log_file_name=""
now I want to disable logs because the current directory is not writeable so I set log_level=0
but pyfmi still tries to open a log file
is this expected, or do we need another log level ?

cc @modelonrobinandersson @agnesramle, since you're working on streams

Hi!

I believe that this is a bug, it seems that we do not take the log level into consideration before we try to open a log file.

[chria]

@jschueller This is now fixed in 2.8.8

[jschueller]

seems it was reverted in 2.8.10, should I reopen ?

[chria]

Correct, It was reverted due to concerns that it might be confusing and cause regressions for users. We'll look at again in the near future so see what we can do to remove some of the concerns that was raised.

[modelonrobinandersson]

By the way @jschueller, if you still have issues with your current directory not being writable, you can now (since last year I believe) log to a stream and that way "get around" the issue with the empty log file being generated. For example we have a few tests where we use io.StringIO. It's not a solution to this issue but just wanted to let you know.

[jschueller]

I have another workaround in the current code: set the file in /tmp:
https://github.com/openturns/otfmi/blob/master/otfmi/fmi.py#L34
but thanks, StringIO is maybe simpler