Skip to content

Commit d7b04ee

Browse files
committed
fix: explicitly close all 8 streams in bidirectional test
- Test was only closing 4 streams, leaving 4 unclosed - Extract streams passed to proxy and close them explicitly - Prevents ResourceWarnings about unclosed MemoryObjectStreams - Each stream pair has both send and receive ends that must be closed
1 parent 65656b6 commit d7b04ee

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

tests/shared/test_proxy.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ async def test_proxy_bidirectional_forwarding(create_streams):
114114
),
115115
) = create_streams()
116116

117+
# Unpack the streams passed to proxy for cleanup
118+
client_read, client_write = client_streams
119+
server_read, server_write = server_streams
120+
117121
try:
118122
# Create test messages
119123
client_request = JSONRPCRequest(jsonrpc="2.0", id="client_1", method="client_method", params={})
@@ -137,11 +141,15 @@ async def test_proxy_bidirectional_forwarding(create_streams):
137141
received_at_client = await client_write_reader.receive()
138142
assert received_at_client.message.root.id == "server_1"
139143
finally:
140-
# Clean up test streams
144+
# Clean up ALL 8 streams
141145
await client_read_writer.aclose()
142146
await client_write_reader.aclose()
143147
await server_read_writer.aclose()
144148
await server_write_reader.aclose()
149+
await client_read.aclose()
150+
await client_write.aclose()
151+
await server_read.aclose()
152+
await server_write.aclose()
145153

146154

147155
@pytest.mark.anyio

0 commit comments

Comments
 (0)