lint

Author: dogacancolak

tests/client/test_auth.py

@@ -78,6 +78,7 @@ async def callback_handler() -> tuple[str, str | None]:
         callback_handler=callback_handler,
     )
 
+
 @pytest.fixture
 def oauth_provider_without_scope(oauth_provider: OAuthClientProvider) -> OAuthClientProvider:
     """Create OAuth provider without predefined scope."""
@@ -119,6 +120,22 @@ def prm_metadata_without_scopes():
         scopes_supported=None,
     )
 
+
+@pytest.fixture
+def oauth_metadata_response_without_scopes():
+    """OAuth metadata response without scopes."""
+    return httpx.Response(
+        200,
+        content=(
+            b'{"issuer": "https://auth.example.com", '
+            b'"authorization_endpoint": "https://auth.example.com/authorize", '
+            b'"token_endpoint": "https://auth.example.com/token", '
+            b'"registration_endpoint": "https://auth.example.com/register"}'
+            # No scopes_supported field
+        ),
+    )
+
+
 class TestPKCEParameters:
     """Test PKCE parameter generation."""
 
@@ -433,8 +450,10 @@ async def test_handle_metadata_response_success(self, oauth_provider: OAuthClien
 
     @pytest.mark.anyio
     async def test_prioritize_prm_scopes_over_oauth_metadata(
-        self, oauth_provider_without_scope: OAuthClientProvider,
-        oauth_metadata_response: httpx.Response, prm_metadata: ProtectedResourceMetadata
+        self,
+        oauth_provider_without_scope: OAuthClientProvider,
+        oauth_metadata_response: httpx.Response,
+        prm_metadata: ProtectedResourceMetadata,
     ):
         """Test that PRM scopes are prioritized over auth server metadata scopes."""
         provider = oauth_provider_without_scope
@@ -450,8 +469,10 @@ async def test_prioritize_prm_scopes_over_oauth_metadata(
 
     @pytest.mark.anyio
     async def test_fallback_to_oauth_metadata_scopes_when_no_prm_scopes(
-        self, oauth_provider_without_scope: OAuthClientProvider,
-        oauth_metadata_response: httpx.Response, prm_metadata_without_scopes: ProtectedResourceMetadata
+        self,
+        oauth_provider_without_scope: OAuthClientProvider,
+        oauth_metadata_response: httpx.Response,
+        prm_metadata_without_scopes: ProtectedResourceMetadata,
     ):
         """Test fallback to OAuth metadata scopes when PRM has no scopes."""
         provider = oauth_provider_without_scope
@@ -467,37 +488,29 @@ async def test_fallback_to_oauth_metadata_scopes_when_no_prm_scopes(
 
     @pytest.mark.anyio
     async def test_no_scope_changes_when_both_missing(
-        self, oauth_provider_without_scope: OAuthClientProvider,
-        prm_metadata_without_scopes: ProtectedResourceMetadata
+        self,
+        oauth_provider_without_scope: OAuthClientProvider,
+        prm_metadata_without_scopes: ProtectedResourceMetadata,
+        oauth_metadata_response_without_scopes: httpx.Response,
     ):
         """Test that no scope changes occur when both PRM and OAuth metadata lack scopes."""
         provider = oauth_provider_without_scope
 
         # Set up PRM metadata without scopes
         provider.context.protected_resource_metadata = prm_metadata_without_scopes
 
-        # Create OAuth metadata response without scopes
-        custom_oauth_metadata_response = httpx.Response(
-            200,
-            content=(
-                b'{"issuer": "https://auth.example.com", '
-                b'"authorization_endpoint": "https://auth.example.com/authorize", '
-                b'"token_endpoint": "https://auth.example.com/token", '
-                b'"registration_endpoint": "https://auth.example.com/register"}'
-                # No scopes_supported field
-            ),
-        )
-
         # Process the OAuth metadata
-        await provider._handle_oauth_metadata_response(custom_oauth_metadata_response)
+        await provider._handle_oauth_metadata_response(oauth_metadata_response_without_scopes)
 
         # Verify that scope remains None
         assert provider.context.client_metadata.scope is None
 
     @pytest.mark.anyio
     async def test_preserve_existing_client_scope(
-        self, oauth_provider: OAuthClientProvider,
-        oauth_metadata_response: httpx.Response, prm_metadata: ProtectedResourceMetadata
+        self,
+        oauth_provider: OAuthClientProvider,
+        oauth_metadata_response: httpx.Response,
+        prm_metadata: ProtectedResourceMetadata,
     ):
         """Test that existing client scope is preserved regardless of metadata."""
         provider = oauth_provider
@@ -1079,4 +1092,3 @@ async def callback_handler() -> tuple[str, str | None]:
 
         result = provider._extract_resource_metadata_from_www_auth(init_response)
         assert result is None, f"Should return None for {description}"
-