fix: resolve pyright type checking errors

Wyn1996 · Wyn1996 · commit 4f47dc2f375e · 2025-10-22T19:58:39.000+08:00
- Add type ignore comments for ExceptionGroup compatibility issues
- Add proper type annotations for find_mcp_error function
- All pre-commit checks now pass including pyright type checking
diff --git a/tests/shared/test_streamable_http.py b/tests/shared/test_streamable_http.py
@@ -14,7 +14,7 @@
 try:
     from builtins import ExceptionGroup
 except ImportError:
-    from exceptiongroup import ExceptionGroup
+    from exceptiongroup import ExceptionGroup  # type: ignore
 
 import anyio
 import httpx
@@ -1615,62 +1615,64 @@ async def test_client_unexpected_content_type_raises_mcp_error():
     async def html_endpoint(request: Request):
         return HTMLResponse("<html><body>Not an MCP server</body></html>")
 
-    app = Starlette(routes=[
-        Route("/mcp", html_endpoint, methods=["GET", "POST"]),
-    ])
-    
+    app = Starlette(
+        routes=[
+            Route("/mcp", html_endpoint, methods=["GET", "POST"]),
+        ]
+    )
+
     # Start server on a random port using a simpler approach
     with socket.socket() as s:
         s.bind(("127.0.0.1", 0))
         port = s.getsockname()[1]
-    
+
     # Use a thread instead of multiprocessing to avoid pickle issues
     import asyncio
     import threading
-    
+
     def run_server():
         loop = asyncio.new_event_loop()
         asyncio.set_event_loop(loop)
         uvicorn.run(app, host="127.0.0.1", port=port, log_level="error")
-    
+
     server_thread = threading.Thread(target=run_server, daemon=True)
     server_thread.start()
-    
+
     try:
         # Give server time to start
         await asyncio.sleep(0.5)
-        
+
         server_url = f"http://127.0.0.1:{port}"
-        
+
         # Test that the client raises McpError when server returns HTML
-        with pytest.raises(ExceptionGroup) as exc_info:
+        with pytest.raises(ExceptionGroup) as exc_info:  # type: ignore
             async with streamablehttp_client(f"{server_url}/mcp") as (
                 read_stream,
                 write_stream,
                 _,
             ):
                 async with ClientSession(read_stream, write_stream) as session:
                     await session.initialize()
-        
+
         # Extract the McpError from the ExceptionGroup (handle nested groups)
         mcp_error = None
-        
-        def find_mcp_error(exc_group):
-            for exc in exc_group.exceptions:
+
+        def find_mcp_error(exc_group: ExceptionGroup) -> McpError | None:  # type: ignore
+            for exc in exc_group.exceptions:  # type: ignore
                 if isinstance(exc, McpError):
                     return exc
-                elif isinstance(exc, ExceptionGroup):
+                elif isinstance(exc, ExceptionGroup):  # type: ignore
                     result = find_mcp_error(exc)
                     if result:
                         return result
             return None
-        
+
         mcp_error = find_mcp_error(exc_info.value)
-        
+
         assert mcp_error is not None, "Expected McpError in ExceptionGroup hierarchy"
         assert "Unexpected content type" in str(mcp_error)
         assert "text/html" in str(mcp_error)
-        
+
     finally:
         # Server thread will be cleaned up automatically as daemon
         pass
