Revert wait_for_server HTTP check; also remove dead code in test_ws.py

The HTTP health check in wait_for_server() caused false-positive readiness
signals for mounted Starlette apps (404 from root vs 404 from uninitialized
routes are indistinguishable). Revert to TCP-only polling which matches the
original behavior.

Also remove the same dead-code pattern from test_ws.py (unreachable loop
after blocking server.run()).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: BabyChrist666

tests/shared/test_ws.py

@@ -1,6 +1,5 @@
 import multiprocessing
 import socket
-import time
 from collections.abc import AsyncGenerator, Generator
 from urllib.parse import urlparse
 
@@ -114,11 +113,6 @@ def run_server(server_port: int) -> None:  # pragma: no cover
     print(f"starting server on {server_port}")
     server.run()
 
-    # Give server time to start
-    while not server.started:
-        print("waiting for server to start")
-        time.sleep(0.5)
-
 
 @pytest.fixture()
 def server(server_port: int) -> Generator[None, None, None]:

tests/test_helpers.py

@@ -2,54 +2,30 @@
 
 import socket
 import time
-import urllib.error
-import urllib.request
 
 
 def wait_for_server(port: int, timeout: float = 20.0) -> None:
     """Wait for server to be ready to accept connections.
 
-    First polls until the TCP port accepts connections, then verifies the
-    HTTP server is actually ready to handle requests. This two-stage check
-    prevents race conditions where the port is open but the ASGI app hasn't
-    finished initializing.
+    Polls the server port until it accepts connections or timeout is reached.
+    This eliminates race conditions without arbitrary sleeps.
 
     Args:
         port: The port number to check
-        timeout: Maximum time to wait in seconds (default 20.0)
+        timeout: Maximum time to wait in seconds (default 5.0)
 
     Raises:
         TimeoutError: If server doesn't start within the timeout period
     """
     start_time = time.time()
-
-    # Stage 1: Wait for TCP port to accept connections
     while time.time() - start_time < timeout:
         try:
             with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
                 s.settimeout(0.1)
                 s.connect(("127.0.0.1", port))
-                break  # Port is open, move to stage 2
+                # Server is ready
+                return
         except (ConnectionRefusedError, OSError):
+            # Server not ready yet, retry quickly
             time.sleep(0.01)
-    else:
-        raise TimeoutError(f"Server on port {port} did not start within {timeout} seconds")  # pragma: no cover
-
-    # Stage 2: Verify HTTP server is ready by making a request.
-    # A non-existent path returns 404/405 if the app is ready, or
-    # raises an error if the ASGI app hasn't finished initializing.
-    while time.time() - start_time < timeout:
-        try:
-            req = urllib.request.Request(
-                f"http://127.0.0.1:{port}/healthz",
-                method="GET",
-            )
-            with urllib.request.urlopen(req, timeout=1):
-                return  # Any successful response means server is ready
-        except urllib.error.HTTPError:
-            # 404/405/etc means the server IS handling requests
-            return
-        except (urllib.error.URLError, ConnectionError, OSError):
-            # Server not ready for HTTP yet
-            time.sleep(0.05)
-    raise TimeoutError(f"Server on port {port} did not become HTTP-ready within {timeout} seconds")  # pragma: no cover
+    raise TimeoutError(f"Server on port {port} did not start within {timeout} seconds")  # pragma: no cover