fix: Resolve pyright type errors in ResourceContents tests

Fixed type narrowing issues in test files that were accessing attributes
on union types without proper isinstance checks. The FastMCP read_resource
method returns ReadResourceContents | TextResourceContents | BlobResourceContents,
requiring explicit type checking before accessing type-specific attributes.

Changes:
- Added proper type narrowing with isinstance() checks in all affected tests
- Fixed incorrect Resource base class usage in test files
- Corrected AnyUrl constructor usage in resource creation
- Updated lowlevel example to avoid delegation conflicts

All tests pass and pyright reports 0 errors.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: alexanderreiff

examples/snippets/servers/lowlevel/resource_contents_direct.py

@@ -245,8 +245,14 @@ async def read_legacy_resource(
             )
         ]
 
-    # Delegate to the new handler for other resources
-    return await read_resource(uri)
+    # For other resources, return a simple not found message
+    return [
+        types.TextResourceContents(
+            uri=uri,
+            text=f"Resource not found: {uri}",
+            mimeType="text/plain",
+        )
+    ]
 
 
 async def main():

tests/issues/test_141_resource_templates.py

@@ -53,8 +53,21 @@ def get_user_profile_missing(user_id: str) -> str:
     result = await mcp.read_resource("resource://users/123/posts/456")
     result_list = list(result)
     assert len(result_list) == 1
-    assert result_list[0].content == "Post 456 by user 123"
-    assert result_list[0].mime_type == "text/plain"
+    content = result_list[0]
+    # Since this is a string resource, it should be wrapped as ReadResourceContents
+    from mcp.server.lowlevel.server import ReadResourceContents
+    from mcp.types import TextResourceContents
+
+    if isinstance(content, ReadResourceContents):
+        assert content.content == "Post 456 by user 123"
+        assert content.mime_type == "text/plain"
+    elif isinstance(content, TextResourceContents):
+        # If it's TextResourceContents (direct return)
+        assert content.text == "Post 456 by user 123"
+        assert content.mimeType == "text/plain"
+    else:
+        # Should not happen for string resources
+        raise AssertionError(f"Unexpected content type: {type(content)}")
 
     # Verify invalid parameters raise error
     with pytest.raises(ValueError, match="Unknown resource"):

tests/server/fastmcp/resources/test_resource_contents_direct.py

@@ -4,7 +4,7 @@
 from pydantic import AnyUrl
 
 from mcp.server.fastmcp import FastMCP
-from mcp.server.fastmcp.resources import TextResource
+from mcp.server.fastmcp.resources import Resource
 from mcp.types import BlobResourceContents, TextResourceContents
 
 
@@ -13,7 +13,7 @@ async def test_resource_returns_text_resource_contents_directly():
     """Test a custom resource that returns TextResourceContents directly."""
     app = FastMCP("test")
 
-    class DirectTextResource(TextResource):
+    class DirectTextResource(Resource):
         """A resource that returns TextResourceContents directly."""
 
         async def read(self):
@@ -27,11 +27,10 @@ async def read(self):
     # Add the resource
     app.add_resource(
         DirectTextResource(
-            uri="resource://direct-text",
+            uri=AnyUrl("resource://direct-text"),
             name="direct-text",
             title="Direct Text Resource",
             description="Returns TextResourceContents directly",
-            text="This is ignored since we override read()",
         )
     )
 
@@ -53,7 +52,7 @@ async def test_resource_returns_blob_resource_contents_directly():
     """Test a custom resource that returns BlobResourceContents directly."""
     app = FastMCP("test")
 
-    class DirectBlobResource(TextResource):
+    class DirectBlobResource(Resource):
         """A resource that returns BlobResourceContents directly."""
 
         async def read(self):
@@ -67,11 +66,10 @@ async def read(self):
     # Add the resource
     app.add_resource(
         DirectBlobResource(
-            uri="resource://direct-blob",
+            uri=AnyUrl("resource://direct-blob"),
             name="direct-blob",
             title="Direct Blob Resource",
             description="Returns BlobResourceContents directly",
-            text="This is ignored since we override read()",
         )
     )
 

tests/server/fastmcp/servers/test_file_server.py

@@ -92,9 +92,19 @@ async def test_read_resource_dir(mcp: FastMCP):
     res_list = list(res_iter)
     assert len(res_list) == 1
     res = res_list[0]
-    assert res.mime_type == "text/plain"
 
-    files = json.loads(res.content)
+    # Handle union type properly
+    from mcp.server.lowlevel.server import ReadResourceContents
+    from mcp.types import TextResourceContents
+
+    if isinstance(res, ReadResourceContents):
+        assert res.mime_type == "text/plain"
+        files = json.loads(res.content)
+    elif isinstance(res, TextResourceContents):
+        assert res.mimeType == "text/plain"
+        files = json.loads(res.text)
+    else:
+        raise AssertionError(f"Unexpected content type: {type(res)}")
 
     assert sorted([Path(f).name for f in files]) == [
         "config.json",
@@ -109,7 +119,17 @@ async def test_read_resource_file(mcp: FastMCP):
     res_list = list(res_iter)
     assert len(res_list) == 1
     res = res_list[0]
-    assert res.content == "print('hello world')"
+
+    # Handle union type properly
+    from mcp.server.lowlevel.server import ReadResourceContents
+    from mcp.types import TextResourceContents
+
+    if isinstance(res, ReadResourceContents):
+        assert res.content == "print('hello world')"
+    elif isinstance(res, TextResourceContents):
+        assert res.text == "print('hello world')"
+    else:
+        raise AssertionError(f"Unexpected content type: {type(res)}")
 
 
 @pytest.mark.anyio
@@ -125,4 +145,14 @@ async def test_delete_file_and_check_resources(mcp: FastMCP, test_dir: Path):
     res_list = list(res_iter)
     assert len(res_list) == 1
     res = res_list[0]
-    assert res.content == "File not found"
+
+    # Handle union type properly
+    from mcp.server.lowlevel.server import ReadResourceContents
+    from mcp.types import TextResourceContents
+
+    if isinstance(res, ReadResourceContents):
+        assert res.content == "File not found"
+    elif isinstance(res, TextResourceContents):
+        assert res.text == "File not found"
+    else:
+        raise AssertionError(f"Unexpected content type: {type(res)}")

tests/server/fastmcp/test_server.py

@@ -1035,7 +1035,16 @@ async def tool_with_resource(ctx: Context[ServerSession, None]) -> str:
             r_list = list(r_iter)
             assert len(r_list) == 1
             r = r_list[0]
-            return f"Read resource: {r.content} with mime type {r.mime_type}"
+            # Handle union type properly
+            from mcp.server.lowlevel.server import ReadResourceContents
+            from mcp.types import TextResourceContents
+
+            if isinstance(r, ReadResourceContents):
+                return f"Read resource: {r.content} with mime type {r.mime_type}"
+            elif isinstance(r, TextResourceContents):
+                return f"Read resource: {r.text} with mime type {r.mimeType}"
+            else:
+                raise AssertionError(f"Unexpected content type: {type(r)}")
 
         async with client_session(mcp._mcp_server) as client:
             result = await client.call_tool("tool_with_resource", {})