-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
enhancementNew feature or requestNew feature or request
Description
As we talked, I would like to implement Bitbucket support in Dispatch and pave the ground for other support such as GitLab. I browsed the code a bit and here is how I'm planning to implement it:
- Add a configuration called
providerwhere you can set eithergithuborbitbucket(defaults to github for backward compatibility) - Move the Github webhook handling in Webhooks.Controller to his own Webhooks.GitHub module
- Rename the
:createaction in Webhooks.Controller for:githubwhich will call the Webhooks.GitHub module (and point the route to :github) - Create Webhooks.Bitbucket module for handling Bitbucket webhook
- Add a POST
:bitbucketaction in Webhooks.Controller which uses the Webhooks.Bitbucket module with a route/webhooks/bitbucket - Add a BitbucketClient that implements ClientBehaviour.
- Make sure that the Client module is used dependant on
providerconfig variable.
Anything I forgot? Any recommandation?
GabDesilets
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request