fix failing tests

Author: eleanorjboyd

src/test/testing/testController/resultResolver.unit.test.ts

@@ -93,12 +93,13 @@ suite('Result Resolver tests', () => {
             // assert the stub functions were called with the correct parameters
 
             // header of populateTestTree is (testController: TestController, testTreeData: DiscoveredTestNode, testRoot: TestItem | undefined, resultResolver: ITestResultResolver, token?: CancellationToken)
+            // After refactor, an inline object with testItemIndex maps is passed instead of resultResolver
             sinon.assert.calledWithMatch(
                 populateTestTreeStub,
                 testController, // testController
                 tests, // testTreeData
                 undefined, // testRoot
-                resultResolver, // resultResolver
+                sinon.match.has('runIdToTestItem'), // inline object with maps
                 cancelationToken, // token
             );
         });
@@ -182,12 +183,13 @@ suite('Result Resolver tests', () => {
             sinon.assert.calledWithMatch(createErrorTestItemStub, sinon.match.any, sinon.match.any);
 
             // also calls populateTestTree with the discovery test results
+            // After refactor, an inline object with testItemIndex maps is passed instead of resultResolver
             sinon.assert.calledWithMatch(
                 populateTestTreeStub,
                 testController, // testController
                 tests, // testTreeData
                 undefined, // testRoot
-                resultResolver, // resultResolver
+                sinon.match.has('runIdToTestItem'), // inline object with maps
                 cancelationToken, // token
             );
         });
@@ -327,20 +329,51 @@ suite('Result Resolver tests', () => {
             sinon.stub(testItemUtilities, 'clearAllChildren').callsFake(() => undefined);
             testProvider = 'unittest';
             workspaceUri = Uri.file('/foo/bar');
+
+            // Create parent test item with correct ID
+            const mockParentItem = createMockTestItem('parentTest');
+
+            // Update testControllerMock to include parent item in its collection
+            const mockTestItems: [string, TestItem][] = [
+                ['1', mockTestItem1],
+                ['2', mockTestItem2],
+                ['parentTest', mockParentItem],
+            ];
+            const iterableMock = mockTestItems[Symbol.iterator]();
+
+            const testItemCollectionMock = typemoq.Mock.ofType<TestItemCollection>();
+            testItemCollectionMock
+                .setup((x) => x.forEach(typemoq.It.isAny()))
+                .callback((callback) => {
+                    let result = iterableMock.next();
+                    while (!result.done) {
+                        callback(result.value[1]);
+                        result = iterableMock.next();
+                    }
+                })
+                .returns(() => mockTestItem1);
+            testItemCollectionMock.setup((x) => x.get('parentTest')).returns(() => mockParentItem);
+
+            testControllerMock.reset();
+            testControllerMock.setup((t) => t.items).returns(() => testItemCollectionMock.object);
+
             resultResolver = new ResultResolver.PythonResultResolver(
                 testControllerMock.object,
                 testProvider,
                 workspaceUri,
             );
             const subtestName = 'parentTest [subTest with spaces and [brackets]]';
             const mockSubtestItem = createMockTestItem(subtestName);
+
             // add a mock test item to the map of known VSCode ids to run ids
             resultResolver.runIdToVSid.set('mockTestItem2', 'mockTestItem2');
             // creates a mock test item with a space which will be used to split the runId
             resultResolver.runIdToVSid.set(subtestName, subtestName);
+            // Register parent test in testItemIndex so it can be found by getTestItem
+            resultResolver.runIdToVSid.set('parentTest', 'parentTest');
 
             // add this mock test to the map of known test items
-            resultResolver.runIdToTestItem.set('parentTest', mockTestItem2);
+            resultResolver.runIdToTestItem.set('parentTest', mockParentItem);
             resultResolver.runIdToTestItem.set(subtestName, mockSubtestItem);
 
             let generatedId: string | undefined;
@@ -563,15 +596,15 @@ suite('Result Resolver tests', () => {
 
 function createMockTestItem(id: string): TestItem {
     const range = new Range(0, 0, 0, 0);
+    const mockChildren = typemoq.Mock.ofType<TestItemCollection>();
+    mockChildren.setup((x) => x.add(typemoq.It.isAny())).returns(() => undefined);
+    mockChildren.setup((x) => x.forEach(typemoq.It.isAny())).returns(() => undefined);
+
     const mockTestItem = ({
         id,
         canResolveChildren: false,
         tags: [],
-        children: {
-            add: () => {
-                // empty
-            },
-        },
+        children: mockChildren.object,
         range,
         uri: Uri.file('/foo/bar'),
     } as unknown) as TestItem;