Quote conda env remove arguments when using full path (#113)

karthiknadig · web-flow · commit 7625c7989213 · 2025-01-14T13:22:43.000-08:00
Closes #103
diff --git a/src/managers/conda/condaUtils.ts b/src/managers/conda/condaUtils.ts
@@ -31,6 +31,7 @@ import { CondaStrings } from '../../common/localize';
 import { showErrorMessage } from '../../common/errors/utils';
 import { showInputBox, showQuickPick, withProgress } from '../../common/window.apis';
 import { Installable, selectFromCommonPackagesToInstall } from '../common/pickers';
+import { quoteArgs } from '../../features/execution/execUtils';
 
 export const CONDA_PATH_KEY = `${ENVS_EXTENSION_ID}:conda:CONDA_PATH`;
 export const CONDA_PREFIXES_KEY = `${ENVS_EXTENSION_ID}:conda:CONDA_PREFIXES`;
@@ -585,7 +586,7 @@ async function createPrefixCondaEnvironment(
 }
 
 export async function deleteCondaEnvironment(environment: PythonEnvironment, log: LogOutputChannel): Promise<boolean> {
-    let args = ['env', 'remove', '--yes', '--prefix', environment.environmentPath.fsPath];
+    let args = quoteArgs(['env', 'remove', '--yes', '--prefix', environment.environmentPath.fsPath]);
     return await withProgress(
         {
             location: ProgressLocation.Notification,

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ import { CondaStrings } from '../../common/localize';`
`31`	`31`	`import { showErrorMessage } from '../../common/errors/utils';`
`32`	`32`	`import { showInputBox, showQuickPick, withProgress } from '../../common/window.apis';`
`33`	`33`	`import { Installable, selectFromCommonPackagesToInstall } from '../common/pickers';`
	`34`	`+import { quoteArgs } from '../../features/execution/execUtils';`
`34`	`35`
`35`	`36`	export const CONDA_PATH_KEY = `${ENVS_EXTENSION_ID}:conda:CONDA_PATH`;
`36`	`37`	export const CONDA_PREFIXES_KEY = `${ENVS_EXTENSION_ID}:conda:CONDA_PREFIXES`;
`@@ -585,7 +586,7 @@ async function createPrefixCondaEnvironment(`
`585`	`586`	`}`
`586`	`587`
`587`	`588`	`export async function deleteCondaEnvironment(environment: PythonEnvironment, log: LogOutputChannel): Promise<boolean> {`
`588`		`- let args = ['env', 'remove', '--yes', '--prefix', environment.environmentPath.fsPath];`
	`589`	`+ let args = quoteArgs(['env', 'remove', '--yes', '--prefix', environment.environmentPath.fsPath]);`
`589`	`590`	`return await withProgress(`
`590`	`591`	`{`
`591`	`592`	`location: ProgressLocation.Notification,`