Skip to content

Commit 8c28428

Browse files
committed
perf: remove useless code
1 parent 3b50acc commit 8c28428

File tree

3 files changed

+25
-25
lines changed

3 files changed

+25
-25
lines changed

src/copilot/contextProvider.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,14 @@ function createJavaContextResolver(): ContextResolverFunction {
7474
async function resolveJavaContext(request: ResolveRequest, copilotCancel: vscode.CancellationToken): Promise<SupportedContextItem[]> {
7575
const items: SupportedContextItem[] = [];
7676
const start = performance.now();
77-
77+
7878
let dependenciesResult: CopilotHelper.IResolveResult | undefined;
7979
let importsResult: CopilotHelper.IResolveResult | undefined;
80-
80+
8181
try {
8282
// Check for cancellation before starting
8383
JavaContextProviderUtils.checkCancellation(copilotCancel);
84-
84+
8585
// Resolve project dependencies and convert to context items
8686
dependenciesResult = await CopilotHelper.resolveAndConvertProjectDependencies(
8787
vscode.window.activeTextEditor,
@@ -104,9 +104,9 @@ async function resolveJavaContext(request: ResolveRequest, copilotCancel: vscode
104104
} catch (error: any) {
105105
if (error instanceof CopilotCancellationError) {
106106
sendContextResolutionTelemetry(
107-
request,
108-
start,
109-
items,
107+
request,
108+
start,
109+
items,
110110
"cancelled_by_copilot",
111111
undefined,
112112
dependenciesResult?.emptyReason,
@@ -118,9 +118,9 @@ async function resolveJavaContext(request: ResolveRequest, copilotCancel: vscode
118118
}
119119
if (error instanceof vscode.CancellationError || error.message === CancellationError.CANCELED) {
120120
sendContextResolutionTelemetry(
121-
request,
122-
start,
123-
items,
121+
request,
122+
start,
123+
items,
124124
"cancelled_internally",
125125
undefined,
126126
dependenciesResult?.emptyReason,
@@ -133,9 +133,9 @@ async function resolveJavaContext(request: ResolveRequest, copilotCancel: vscode
133133

134134
// Send telemetry for general errors (but continue with partial results)
135135
sendContextResolutionTelemetry(
136-
request,
137-
start,
138-
items,
136+
request,
137+
start,
138+
items,
139139
"error_partial_results",
140140
error.message || "unknown_error",
141141
dependenciesResult?.emptyReason,
@@ -150,9 +150,9 @@ async function resolveJavaContext(request: ResolveRequest, copilotCancel: vscode
150150

151151
// Send telemetry data once at the end for success case
152152
sendContextResolutionTelemetry(
153-
request,
154-
start,
155-
items,
153+
request,
154+
start,
155+
items,
156156
"succeeded",
157157
undefined,
158158
dependenciesResult?.emptyReason,

src/copilot/copilotHelper.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export namespace CopilotHelper {
7373
Commands.JAVA_PROJECT_GET_IMPORT_CLASS_CONTENT,
7474
normalizedUri
7575
) as Promise<IImportClassContentResult>;
76-
76+
7777
// Build promises array for race condition
7878
// Note: Client-side timeout is NECESSARY even if backend has timeout because:
7979
// 1. Network delays may prevent backend response from arriving
@@ -87,7 +87,7 @@ export namespace CopilotHelper {
8787
}, 80); // 80ms client-side timeout (independent of backend timeout)
8888
})
8989
];
90-
90+
9191
// Add cancellation promise if token provided
9292
if (cancellationToken) {
9393
promises.push(
@@ -98,7 +98,7 @@ export namespace CopilotHelper {
9898
})
9999
);
100100
}
101-
101+
102102
const result = await Promise.race(promises);
103103
if (!result) {
104104
return {
@@ -171,7 +171,7 @@ export namespace CopilotHelper {
171171
}, 40); // 40ms client-side timeout (independent of backend timeout)
172172
})
173173
];
174-
174+
175175
// Add cancellation promise if token provided
176176
if (cancellationToken) {
177177
promises.push(
@@ -182,7 +182,7 @@ export namespace CopilotHelper {
182182
})
183183
);
184184
}
185-
185+
186186
const result = await Promise.race(promises);
187187
if (!result) {
188188
return {
@@ -238,7 +238,7 @@ export namespace CopilotHelper {
238238
checkCancellation: (token: CancellationToken) => void
239239
): Promise<IResolveResult> {
240240
const items: any[] = [];
241-
241+
242242
// Check if active editor exists
243243
if (!activeEditor) {
244244
return { items: [], emptyReason: EmptyReason.NoActiveEditor, itemCount: 0 };
@@ -287,7 +287,7 @@ export namespace CopilotHelper {
287287
checkCancellation: (token: CancellationToken) => void
288288
): Promise<IResolveResult> {
289289
const items: any[] = [];
290-
290+
291291
// Check if there's an active editor with a Java document
292292
if (!activeEditor) {
293293
return { items: [], emptyReason: EmptyReason.NoActiveEditor, itemCount: 0 };
@@ -310,7 +310,7 @@ export namespace CopilotHelper {
310310
if (importClassResult.isEmpty && importClassResult.emptyReason) {
311311
return { items: [], emptyReason: importClassResult.emptyReason, itemCount: 0 };
312312
}
313-
313+
314314
// Check for cancellation before processing results
315315
checkCancellation(copilotCancel);
316316
if (importClassResult.classInfoList && importClassResult.classInfoList.length > 0) {

src/copilot/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ export function sendContextResolutionTelemetry(
248248
"dependenciesCount": dependenciesCount ?? 0,
249249
"importsCount": importsCount ?? 0
250250
};
251-
251+
252252
// Add empty reasons if present
253253
if (dependenciesEmptyReason) {
254254
telemetryData.dependenciesEmptyReason = dependenciesEmptyReason;
@@ -259,6 +259,6 @@ export function sendContextResolutionTelemetry(
259259
if (error) {
260260
telemetryData.error = error;
261261
}
262-
262+
263263
sendInfo("", telemetryData);
264264
}

0 commit comments

Comments
 (0)