fix(upgrade): check extension version before calling gotoAgentMode

Previously checkOrInstallAppModExtensionForUpgrade only checked if the
extension was installed, not whether it was new enough to support
gotoAgentMode. This caused 67% of upgrade failures (~14K users/day).

Now checks extension.packageJSON.version >= MIN_APPMOD_VERSION. If too
old, triggers update and verifies command availability with timeout.

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>

Author: FrankLiu4138

src/constants.ts

@@ -41,6 +41,8 @@ export namespace ExtensionName {
 
 export namespace Upgrade {
     export const PACKAGE_ID_FOR_JAVA_RUNTIME = "java:*";
+    /** Minimum version of the appmod extension that supports gotoAgentMode command */
+    export const MIN_APPMOD_VERSION = "0.0.1"; // TODO: replace with actual minimum version
 }
 
 /**

src/upgrade/utility.ts

@@ -5,6 +5,7 @@ import { commands, extensions, Uri, window } from "vscode";
 import * as semver from "semver";
 import { UpgradeReason, type UpgradeIssue } from "./type";
 import { ExtensionName, Upgrade } from "../constants";
+import { Commands } from "../commands";
 import { instrumentOperation, sendInfo } from "vscode-extension-telemetry-wrapper";
 import { CveUpgradeIssue } from "./cve";
 
@@ -155,10 +156,37 @@ export async function checkOrPopupToInstallAppModExtensionForModernization(
 
 export async function checkOrInstallAppModExtensionForUpgrade(
     extensionIdToCheck: string): Promise<void> {
-    if (extensions.getExtension(extensionIdToCheck)) {
-        return;
+    const ext = extensions.getExtension(extensionIdToCheck);
+
+    if (ext) {
+        const installedVersion = ext.packageJSON?.version;
+        if (installedVersion && semver.gte(installedVersion, Upgrade.MIN_APPMOD_VERSION)) {
+            return;
+        }
+        // Extension is installed but too old — update it
+        sendInfo("", {
+            operationName: "java.dependency.upgrade.extensionOutdated",
+            installedVersion,
+            minRequiredVersion: Upgrade.MIN_APPMOD_VERSION,
+        });
+        await commands.executeCommand("workbench.extensions.installExtension", ExtensionName.APP_MODERNIZATION_FOR_JAVA);
+    } else {
+        await commands.executeCommand("workbench.extensions.installExtension", ExtensionName.APP_MODERNIZATION_FOR_JAVA);
+        await checkOrPromptToEnableAppModExtension("upgrade");
     }
 
-    await commands.executeCommand("workbench.extensions.installExtension", ExtensionName.APP_MODERNIZATION_FOR_JAVA);
-    await checkOrPromptToEnableAppModExtension("upgrade");
+    // Verify gotoAgentMode command is available after install/update
+    await waitForCommand(Commands.GOTO_AGENT_MODE);
+}
+
+async function waitForCommand(commandId: string, timeoutMs: number = 10000): Promise<void> {
+    const startTime = Date.now();
+    while (Date.now() - startTime < timeoutMs) {
+        const allCommands = await commands.getCommands(true);
+        if (allCommands.includes(commandId)) {
+            return;
+        }
+        await new Promise(resolve => setTimeout(resolve, 500));
+    }
+    throw new Error(`Command '${commandId}' not available after extension install/update. Please reload VS Code and try again.`);
 }