fix(notification): distinguish "update" vs "install" in message body

Change buildNotificationMessage/buildCVENotificationMessage to accept
ExtensionState instead of boolean. Outdated extension now shows
"update extension and upgrade/fix" while not-installed shows
"install extension and upgrade/fix" in both button and message.

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>

Author: FrankLiu4138

src/upgrade/display/notificationManager.ts

@@ -4,7 +4,7 @@
 import { commands, ExtensionContext, extensions, window } from "vscode";
 import * as semver from "semver";
 import { UpgradeReason, type IUpgradeIssuesRenderer, type UpgradeIssue } from "../type";
-import { buildCVENotificationMessage, buildFixPrompt, buildNotificationMessage } from "../utility";
+import { buildCVENotificationMessage, buildFixPrompt, buildNotificationMessage, type ExtensionState } from "../utility";
 import { Commands } from "../../commands";
 import { Settings } from "../../settings";
 import { instrumentOperation, sendInfo } from "vscode-extension-telemetry-wrapper";
@@ -29,7 +29,7 @@ function getNowTs() {
     return Number(new Date()) / 1000;
 }
 
-export type ExtensionState = "up-to-date" | "outdated" | "not-installed";
+export type { ExtensionState } from "../utility";
 
 export interface NotificationContent {
     message: string;
@@ -58,11 +58,10 @@ export function buildNotificationContent(
         (i) => i.reason !== UpgradeReason.CVE
     );
     const hasCVEIssue = cveIssues.length > 0;
-    const isReady = extensionState === "up-to-date";
 
     const message = hasCVEIssue
-        ? buildCVENotificationMessage(cveIssues, isReady)
-        : buildNotificationMessage(nonCVEIssues[0], isReady);
+        ? buildCVENotificationMessage(cveIssues, extensionState)
+        : buildNotificationMessage(nonCVEIssues[0], extensionState);
 
     let upgradeButtonText: string;
     let fixCVEButtonText: string;

src/upgrade/utility.ts

@@ -22,7 +22,20 @@ function findEolDate(currentVersion: string, eolDate: Record<string, string>): s
     return null;
 }
 
-export function buildNotificationMessage(issue: UpgradeIssue, hasExtension: boolean): string {
+export type ExtensionState = "up-to-date" | "outdated" | "not-installed";
+
+function getActionWord(extensionState: ExtensionState, verb: string): string {
+    switch (extensionState) {
+        case "up-to-date":
+            return verb;
+        case "outdated":
+            return `update ${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension and ${verb}`;
+        case "not-installed":
+            return `install ${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension and ${verb}`;
+    }
+}
+
+export function buildNotificationMessage(issue: UpgradeIssue, extensionState: ExtensionState): string {
     const {
         packageId,
         currentVersion,
@@ -31,7 +44,7 @@ export function buildNotificationMessage(issue: UpgradeIssue, hasExtension: bool
         packageDisplayName
     } = issue;
 
-    const upgradeWord = hasExtension ? "upgrade" : `install ${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension and upgrade`;
+    const upgradeWord = getActionWord(extensionState, "upgrade");
 
     if (packageId === Upgrade.PACKAGE_ID_FOR_JAVA_RUNTIME) {
         return `This project is using an older Java runtime (${currentVersion}). Would you like to ${upgradeWord} it to the latest LTS version?`;
@@ -51,7 +64,7 @@ export function buildNotificationMessage(issue: UpgradeIssue, hasExtension: bool
     }
 }
 
-export function buildCVENotificationMessage(issues: CveUpgradeIssue[], hasExtension: boolean): string {
+export function buildCVENotificationMessage(issues: CveUpgradeIssue[], extensionState: ExtensionState): string {
 
     if (issues.length === 0) {
         return "No CVE issues found.";
@@ -81,7 +94,7 @@ export function buildCVENotificationMessage(issues: CveUpgradeIssue[], hasExtens
       CVESeverityDistribution: severityText,
     });
 
-    const fixWord = hasExtension ? "fix" : `install ${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension and fix`;
+    const fixWord = getActionWord(extensionState, "fix");
 
     if (issues.length === 1) {
       return `${severityText} CVE vulnerability is detected in this project. Would you like to ${fixWord} it now?`;
@@ -102,7 +115,7 @@ export function buildFixPrompt(issue: UpgradeIssue): string {
             return `upgrade ${packageDisplayName} to ${suggestedVersionName}`;
         }
         case UpgradeReason.CVE: {
-            return `fix all critical and high-severity CVE vulnerabilities in this project by invoking #appmod-validate-cves-for-java`;
+            return `fix all CVE vulnerabilities in this project`;
         }
     }
 }