Skip to content

Commit a13528c

Browse files
committed
nes: next-cursor: enforce max_tokens of 4 tokens
1 parent df4e20a commit a13528c

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/extension/xtab/node/xtabNextCursorPredictor.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { ChatFetchResponseType, ChatLocation } from '../../../platform/chat/comm
88
import { ConfigKey, IConfigurationService } from '../../../platform/configuration/common/configurationService';
99
import { ChatEndpoint } from '../../../platform/endpoint/node/chatEndpoint';
1010
import { NextCursorLinePrediction } from '../../../platform/inlineEdits/common/dataTypes/nextCursorLinePrediction';
11+
import { OptionalChatRequestParams } from '../../../platform/networking/common/fetch';
1112
import { IExperimentationService } from '../../../platform/telemetry/common/nullExperimentationService';
1213
import { fromUnknown } from '../../../util/common/errors';
1314
import { Result } from '../../../util/common/result';
@@ -148,15 +149,20 @@ export class XtabNextCursorPredictor {
148149
},
149150
});
150151

152+
const maxResponseTokens = this.configService.getExperimentBasedConfig(ConfigKey.TeamInternal.InlineEditsNextCursorPredictionMaxResponseTokens, this.expService);
153+
154+
const requestOptions = {
155+
max_tokens: maxResponseTokens,
156+
secretKey,
157+
} satisfies OptionalChatRequestParams;
158+
151159
const response = await endpoint.makeChatRequest2(
152160
{
153161
messages,
154162
debugName: 'nes.nextCursorPosition',
155163
finishedCb: undefined,
156164
location: ChatLocation.Other,
157-
requestOptions: secretKey ? {
158-
secretKey,
159-
} : undefined,
165+
requestOptions,
160166
},
161167
CancellationToken.None,
162168
);

src/platform/configuration/common/configurationService.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -738,6 +738,7 @@ export namespace ConfigKey {
738738
export const InlineEditsUnification = defineTeamInternalSetting<boolean>('chat.advanced.inlineEdits.unification', ConfigType.ExperimentBased, false);
739739
export const InlineEditsNextCursorPredictionEnabled = defineTeamInternalSetting<NextCursorLinePrediction | boolean | undefined>('chat.advanced.inlineEdits.nextCursorPrediction.enabled', ConfigType.ExperimentBased, { defaultValue: undefined, teamDefaultValue: NextCursorLinePrediction.OnlyWithEdit });
740740
export const InlineEditsNextCursorPredictionModelName = defineTeamInternalSetting<string | undefined>('chat.advanced.inlineEdits.nextCursorPrediction.modelName', ConfigType.ExperimentBased, "xtab-cursor-jump-1104");
741+
export const InlineEditsNextCursorPredictionMaxResponseTokens = defineTeamInternalSetting<number>('chat.advanced.inlineEdits.nextCursorPrediction.maxResponseTokens', ConfigType.ExperimentBased, 4);
741742
export const InlineEditsXtabProviderModelConfigurationString = defineTeamInternalSetting<string | undefined>('chat.advanced.inlineEdits.xtabProvider.modelConfigurationString', ConfigType.ExperimentBased, undefined);
742743
export const InlineEditsXtabProviderDefaultModelConfigurationString = defineTeamInternalSetting<string | undefined>('chat.advanced.inlineEdits.xtabProvider.defaultModelConfigurationString', ConfigType.ExperimentBased, undefined);
743744
export const InlineEditsXtabProviderUseVaryingLinesAbove = defineTeamInternalSetting<boolean | undefined>('chat.advanced.inlineEdits.xtabProvider.useVaryingLinesAbove', ConfigType.ExperimentBased, undefined);

0 commit comments

Comments
 (0)